You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by gadLinux <gi...@git.apache.org> on 2017/05/25 15:14:47 UTC
[GitHub] thrift pull request #1278: THRIFT-4211: Fix logging in thrift library
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/1278
THRIFT-4211: Fix logging in thrift library
It seems we were aborting on error.
We are now doing properly management. Error is ok and working perfectly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gadLinux/thrift THRIFT-4211
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1278
----
commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date: 2017-05-25T15:11:38Z
Fix logging in thrift library in #THRIFT-4211
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1278: THRIFT-4211: Fix logging in thrift library
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1278
---
[GitHub] thrift issue #1278: THRIFT-4211: Fix logging in thrift library
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1278
Would you be able to rebase against master and push so there is one commit (just like there is now), but more importantly it will kick off a new CI build for us. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1278: THRIFT-4211: Fix logging in thrift library
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1278
Please rebase on master and push to get a new Travis CI build, now that it has been cleaned up.
---