You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/29 13:53:03 UTC

[GitHub] [netbeans] dbalek opened a new pull request #2718: Fixing failing build.

dbalek opened a new pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718


   - `PrepareBundles` task should use the same versions of NPMs as the extension itself
   - stop LSP client before killing server while restarting NBLS 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771835707


   @neilcsmith-net - I assume apache:delivery is enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek merged pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek commented on a change in pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#discussion_r568414328



##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -41,7 +41,7 @@ import * as launcher from './nbcode';
 import { StatusMessageRequest, ShowStatusMessageParams, QuickPickRequest, InputBoxRequest } from './protocol';
 
 const API_VERSION : string = "1.0";
-let client: Promise<LanguageClient>;
+let client: Promise<LanguageClient> | null = null;

Review comment:
       Agreed. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin edited a comment on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
MartinBalin edited a comment on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771835707


   @neilcsmith-net - I assume apache:delivery is enough?? or let us know, still learning this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771503500


   @MartinBalin @dbalek we'll be looking to merge today to trigger beta2 for tomorrow.  I assume this is now ready? Please can you squash and force push your branch into a single commit for merging.
   
   In terms of the beta for VSCode, that task seems to be building master?  We need a build off of release123, and we should do the VSCode beta2 off of the same commit as the rest of beta2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771471013






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771503500






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek merged pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771912103


   This PR has been merged into `delivery`. It is going to become part of 12.3 once @neilcsmith-net merges that branch into 12.3 line. All is good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#discussion_r567702175



##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -41,7 +41,7 @@ import * as launcher from './nbcode';
 import { StatusMessageRequest, ShowStatusMessageParams, QuickPickRequest, InputBoxRequest } from './protocol';
 
 const API_VERSION : string = "1.0";
-let client: Promise<LanguageClient>;
+let client: Promise<LanguageClient> | null = null;

Review comment:
       Ideally this `client` promise could be set soon to be defined (not `undefined`) and resolved later. That would mean to make sure the `client` promise is set sooner then `registerCommand` is registered. E.g. 
   ```
   let c : LanguageClient = await client
   ```
   can only be called when the `client` is defined.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771912103


   This PR has been merged into `delivery`. It is going to become part of 12.3 once @neilcsmith-net merges that branch into 12.3 line. All is good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
MartinBalin commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771471013


   This is the change to build so we have 12.3 Beta binaries of VSCode for testing, available https://ci-builds.apache.org/job/Netbeans/view/vscode/job/netbeans-vscode/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771843057


   @MartinBalin for build or integration? Individual PRs merge to delivery, but beta and release builds must be off releaseXXX - the actual beta and release git tags and hashes will not be on any other branch. Waiting on a PR, but that branch should be up-to-date tomorrow. The git hash is embedded in modules as the implementation version and should be part of release checks on any binary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] dbalek commented on a change in pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#discussion_r568414328



##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -41,7 +41,7 @@ import * as launcher from './nbcode';
 import { StatusMessageRequest, ShowStatusMessageParams, QuickPickRequest, InputBoxRequest } from './protocol';
 
 const API_VERSION : string = "1.0";
-let client: Promise<LanguageClient>;
+let client: Promise<LanguageClient> | null = null;

Review comment:
       Agreed. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] MartinBalin edited a comment on pull request #2718: Fixing failing build.

Posted by GitBox <gi...@apache.org>.
MartinBalin edited a comment on pull request #2718:
URL: https://github.com/apache/netbeans/pull/2718#issuecomment-771835707


   @neilcsmith-net - I assume apache:delivery is enough?? or let us know, still learning this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists