You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "gengshaoguang (JIRA)" <tu...@ws.apache.org> on 2007/07/27 09:16:04 UTC

[jira] Created: (TUSCANY-1485) removed Visitor.java and Visitable.java

removed Visitor.java and Visitable.java
---------------------------------------

                 Key: TUSCANY-1485
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
             Project: Tuscany
          Issue Type: Improvement
          Components: Java SCA Core Runtime
    Affects Versions: Java-SCA-Next
         Environment: win2k jdk1.5
            Reporter: gengshaoguang


This issue is to respond Jean-Sebastien Delfino's letter to me.

I checked out /java/sca/modules revision 560118

add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)

remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly

I updated the following code (remove dependence to Visitor and Visitable)

assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java

assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java

core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java

Then mvn the whole project, all testcases works fine.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Sebastien Delfino resolved TUSCANY-1485.
---------------------------------------------

    Resolution: Fixed

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>            Assignee: Jean-Sebastien Delfino
>         Attachments: modules.rar, mypatch.txt
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Assigned: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Sebastien Delfino reassigned TUSCANY-1485:
-----------------------------------------------

    Assignee: Jean-Sebastien Delfino

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>            Assignee: Jean-Sebastien Delfino
>         Attachments: modules.rar, mypatch.txt
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Sebastien Delfino updated TUSCANY-1485:
--------------------------------------------

    Patch Info: [Patch Available]

Checked the patch available checkbox. This notifies everybody that there's a patch available in the JIRA which we need to review, doing this will help your patch get reviewed and applied quicker :)

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>            Assignee: Jean-Sebastien Delfino
>         Attachments: modules.rar, mypatch.txt
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515977 ] 

Raymond Feng commented on TUSCANY-1485:
---------------------------------------

Hi,

Can you run "svn diff>mypatch.txt" command and apply the patch here?

Thanks,
Raymond

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516513 ] 

Jean-Sebastien Delfino commented on TUSCANY-1485:
-------------------------------------------------

I applied the changes in your patch, except for the changes in sca-api/pom.xml and core-spi/pom.xml which didn't seem to be related to the Visitor pattern change.

Thanks for contributing to Tuscany!

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>            Assignee: Jean-Sebastien Delfino
>         Attachments: modules.rar, mypatch.txt
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "gengshaoguang (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gengshaoguang updated TUSCANY-1485:
-----------------------------------

    Attachment: modules.rar

This is updated sca/modules directory in my PC

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>         Attachments: modules.rar
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1485) removed Visitor.java and Visitable.java

Posted by "gengshaoguang (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gengshaoguang updated TUSCANY-1485:
-----------------------------------

    Attachment: mypatch.txt

result of svn diff (inside sca/modules)

> removed Visitor.java and Visitable.java
> ---------------------------------------
>
>                 Key: TUSCANY-1485
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1485
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: win2k jdk1.5
>            Reporter: gengshaoguang
>         Attachments: modules.rar, mypatch.txt
>
>
> This issue is to respond Jean-Sebastien Delfino's letter to me.
> I checked out /java/sca/modules revision 560118
> add <version 2.3-SNAPSHOT to maven-javadoc-plugin under sca-api and core-spi(missing here or the project will not run)
> remove Visitor.java and Visitable.java from modules\assembly\src\main\java\org\apache\tuscany\sca\assembly
> I updated the following code (remove dependence to Visitor and Visitable)
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Component.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\Composite.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CompositeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\BaseImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ConstrainingTypeImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\ComponentImpl.java
> assembly\src\main\java\org\apache\tuscany\sca\assembly\impl\CallbackImpl.java
> core-spring\src\main\java\org\apache\tuscany\sca\core\spring\assembly\impl\BeanComponentImpl.java
> Then mvn the whole project, all testcases works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org