You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Eli Collins (Commented) (JIRA)" <ji...@apache.org> on 2011/11/27 21:15:41 UTC

[jira] [Commented] (MAPREDUCE-3238) Small cleanup in SchedulerApp

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157988#comment-13157988 ] 

Eli Collins commented on MAPREDUCE-3238:
----------------------------------------

+1  lgtm
                
> Small cleanup in SchedulerApp
> -----------------------------
>
>                 Key: MAPREDUCE-3238
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3238
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mr-3238.txt
>
>
> While reading this code, I did a little bit of cleanup:
> - added some javadoc
> - rather than using a Map<Priority, Integer> for keeping counts, switched to Guava's HashMultiset, which makes a simpler API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira