You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/26 12:11:56 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

WeiZhong94 opened a new pull request #12992:
URL: https://github.com/apache/flink/pull/12992


   ## What is the purpose of the change
   
   *This pull request removes the deprecated execute and insert_into calls in PyFlink Table API docs.*
   
   
   ## Brief change log
   
     - *Remove the deprecated execute and insert_into calls in PyFlink Table API docs.*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663982442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7c53366ee4c2dd53f6689ea7caf9f819502d8426 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663982442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906",
       "triggerID" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7c53366ee4c2dd53f6689ea7caf9f819502d8426 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906) 
   * a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663980522


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7c53366ee4c2dd53f6689ea7caf9f819502d8426 (Sun Jul 26 12:14:10 UTC 2020)
   
   **Warnings:**
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18716).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663982442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906",
       "triggerID" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8880",
       "triggerID" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4880bcf317d80dcf5020e2fac1d0508e822ce7ca",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8896",
       "triggerID" : "4880bcf317d80dcf5020e2fac1d0508e822ce7ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4880bcf317d80dcf5020e2fac1d0508e822ce7ca Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8896) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12992:
URL: https://github.com/apache/flink/pull/12992


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663982442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906",
       "triggerID" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7c53366ee4c2dd53f6689ea7caf9f819502d8426 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-663982442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4906",
       "triggerID" : "7c53366ee4c2dd53f6689ea7caf9f819502d8426",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8880",
       "triggerID" : "a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4880bcf317d80dcf5020e2fac1d0508e822ce7ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4880bcf317d80dcf5020e2fac1d0508e822ce7ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a828188358ea6b2af6eb0dfc9ef3ad0358ea78d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8880) 
   * 4880bcf317d80dcf5020e2fac1d0508e822ce7ca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12992: [FLINK-18716][python][docs] Remove the deprecated execute and insert_into calls in PyFlink Table API docs.

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12992:
URL: https://github.com/apache/flink/pull/12992#issuecomment-690119048


   @WeiZhong94 could you rebase the PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org