You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2008/06/20 08:03:45 UTC
[jira] Created: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
AUTH_ID not handled correctly when no auth ids are present
----------------------------------------------------------
Key: ZOOKEEPER-48
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
Project: Zookeeper
Issue Type: Bug
Components: server
Reporter: Benjamin Reed
AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-48:
----------------------------------
Hadoop Flags: [Reviewed]
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: acl-2.patch
The last patch did not throw an exception if AUTH_ID was used on a non authenticated connection and there were other Ids in the list. The patch fixes the issue adds a test to verify and also fixes some overly severe logging problems.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl-2.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: (was: acl.patch)
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl-2.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-48:
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
Committed revision 681465.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Fix For: 3.0.0
>
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-48:
-------------------------------------
Assignee: Benjamin Reed
Ben what's the status on this one? Is it ready for review or further work needs to be done?
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Attachments: acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607276#action_12607276 ]
Patrick Hunt commented on ZOOKEEPER-48:
---------------------------------------
4) this line is in the static initializer for the class - so it will typically be called once per run of the vm
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: acl.patch
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: acl_3.patch
Since the fix for this issue overlaps with ZOOKEEPER-49 and since the fix and test for ZOOKEEPER-49 are so trival, I've included them in this patch.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl-2.patch, acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607273#action_12607273 ]
Benjamin Reed commented on ZOOKEEPER-48:
----------------------------------------
1) done
2) will do once we have a repository to check into so that I can construct a proper patch
3) we should probably open a new jira. I'm not really sure what the correct behavior is...
4) this would create a large number of messages in the log. I would think we would only log it once at startup.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: (was: acl_3.patch)
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: (was: acl-2.patch)
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607280#action_12607280 ]
Benjamin Reed commented on ZOOKEEPER-48:
----------------------------------------
Oh right. Sorry, I wasn't looking at the line number close enough. I'll fix 4) as well in the next patch.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606842#action_12606842 ]
Patrick Hunt commented on ZOOKEEPER-48:
---------------------------------------
I reviewed the patch, great to see that we are adding a test for this. ;-)
Some comments:
1) if attached patch3 supersedes patch 2 please remove 2.
2) could you add documentation for "fixupACL" method? there's quite a bit going on in that method and it's not really clear what the contract is.
3) line 409 (fixupacl method) logs error for "missing authenciation provider...", is this really an error? (no exception thrown as a result...) should we be notifying the client in this case (might help with client side debugging. Perhaps a new jira for this?
4) line 65 preprequestprocessor.java, could we log an INFO message here that states that acl checking is being skipped (might help w/debugging down the road).
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Attachments: acl-2.patch, acl_3.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Attachment: acl_4.patch
Added documentation to fixupACL and added an INFO message if ACLs are skipped.
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-48:
-----------------------------------
Status: Patch Available (was: Open)
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-48) AUTH_ID not handled correctly when
no auth ids are present
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619399#action_12619399 ]
Hudson commented on ZOOKEEPER-48:
---------------------------------
Integrated in ZooKeeper-trunk #42 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/42/])
> AUTH_ID not handled correctly when no auth ids are present
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-48
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-48
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Fix For: 3.0.0
>
> Attachments: acl_4.patch
>
>
> AUTH_ID is used (usually done using Ids.CREATOR_ALL_ACL ) to represent the id that was used to authenticate with ZooKeeper. Thus, an exception should be raised if there are no authenticated ids present. Currently, the exception is not being raised.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.