You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/28 10:34:20 UTC

[GitHub] [incubator-dolphinscheduler] wuzhipeng7cc opened a new issue #2559: [Feature]unique processdefinition name in the same project

wuzhipeng7cc opened a new issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559


   **branch**
   dev
   **Is your feature request related to a problem? Please describe.**
   if the same name in one project ,im hard to recognize any one . And its usually caused by mistake
   
   **Describe the solution you'd like**
   unique processDifinition name in one project
   
   **Additional context**
   name suffix is also good


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] wuzhipeng7cc commented on issue #2559: [Feature]unique processdefinition name in the same project

Posted by GitBox <gi...@apache.org>.
wuzhipeng7cc commented on issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559#issuecomment-620941601


   @dailidong  i'd found that checked by ProcessDefinitionController.verifyProcessDefinitionName
   and i didn't see the unique constraint on t_ds_process_definition's ddl with the name and project_id column. i think it maybe cause some problem In concurrent mode 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] simon824 commented on issue #2559: [Feature]unique processdefinition name in the same project

Posted by GitBox <gi...@apache.org>.
simon824 commented on issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559#issuecomment-620949310


   i will fix it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #2559: [Feature]unique processdefinition name in the same project

Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559#issuecomment-620944326


   1.If the workflow definition is verified to be unique through the normal operation of the dag page, as shown in the following figure
   如果通过dag页面正常操作校验了工作流定义名称唯一,如下图所示
   ![image](https://user-images.githubusercontent.com/55787491/80553327-fc3eeb80-89fb-11ea-8549-9cd8e58615a8.png)
   
   2.If you create workflow definitions concurrently through tools, you can create multiple workflow definitions with the same name. Import workflows also have this problem. Same as # 2538
   如果通过工具并发创建工作流定义,可以创建多个同名的工作流定义,导入工作流也有该问题同#2538
   ![image](https://user-images.githubusercontent.com/55787491/80553754-80de3980-89fd-11ea-91a8-428c776746fc.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #2559: [Feature]unique processdefinition name in the same project

Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559#issuecomment-620947359


   who can fix it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2559: [Feature]unique processdefinition name in the same project

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2559:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2559#issuecomment-620623883


   I don't test dev branch for now, 
   as I know, version 1.2.0 1.2.1 not exists this situation,  when save Process Definition, it will check the name aleady exists or not
   
   @xingchun-chen please verify this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org