You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/06/13 16:09:01 UTC
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13634
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
IMPALA-8436: Do not create materialized_view in Kudu/HBase
IMPALA-8436 broke the dataload on Hive 3, because it tried to
create materialized_view for file formats where its base table
does not exist.
Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
---
M testdata/datasets/functional/schema_constraints.csv
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13634/1
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Sudhanshu Arora (Code Review)" <ge...@cloudera.org>.
Sudhanshu Arora has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 20:36:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4470/
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 20:01:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4473/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 09:56:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 15:17:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 09:56:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3613/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:58:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:36:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4470/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:43:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 2:
The cause of the build failure is an unrelated mvn issue, restarting the job.
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 09:56:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:43:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13634 )
Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase
......................................................................
IMPALA-8436: Do not create materialized_view in Kudu/HBase
IMPALA-8436 broke the dataload on Hive 3, because it tried to
create materialized_view for file formats where its base table
does not exist.
Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Reviewed-on: http://gerrit.cloudera.org:8080/13634
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/datasets/functional/schema_constraints.csv
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefe2b32f4cafe9988051b69cefcc1c1f5d4c79e7
Gerrit-Change-Number: 13634
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <su...@cloudera.com>