[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2442: SOLR-15205: don't mention (deprecated) CloudSolrClient.setIdField in javadocs

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r585586764



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##########
@@ -32,10 +32,6 @@
  * Solr endpoints for SolrCloud collections, and then use the
  * {@link LBHttp2SolrClient} to issue requests.
  *
- * This class assumes the id field for your documents is called
- * 'id' - if this is not the case, you must set the right name

Review comment:
       Hmm, tricky. So the https://github.com/apache/lucene-solr/commit/f9410e14614d1f9ebb88226c287f38cd4d0b3d1f commit removes the `idField = ID` and replaces it with `routeFieldDeprecated = null` i.e. no more use of "id" there but ...
   
   When it comes to `routeFieldDeprecated` usage at https://github.com/apache/lucene-solr/blob/releases/lucene-solr%2F8.7.0/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java#L526-L527 we have
   ```
   ...
   String routeField = (routeFieldDeprecated != null) ? routeFieldDeprecated :
           (col.getRouter().getRouteField(col) == null) ? ID : col.getRouter().getRouteField(col);
   ...
   ```
   i.e. yes in conjunction with the "the field is automatically determined from Zookeeper" comment at https://github.com/apache/lucene-solr/blob/releases/lucene-solr%2F8.7.0/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java#L311 there is an "id" assumption of sorts, though in most use cases the field would be automatically determined from ZooKeeper I guess?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org