You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "desruisseaux (via GitHub)" <gi...@apache.org> on 2025/10/19 08:29:37 UTC
[PR] Delete also the directories specified in `` [maven-clean-plugin]
desruisseaux opened a new pull request, #276:
URL: https://github.com/apache/maven-clean-plugin/pull/276
Each `<source>` element (new in Maven 4) can have an optional `<targetPath>` element. If this element is specified, it should also be deleted by the Maven Clean Plugin. This change completes the current Maven 3 behaviour, which deletes also the directories specified by the `<sourceDirectory>` and `<testSourceDirectory>` elements.
This pull request also modifies the list of directories for removing redundancies. For example, if the plugin deletes the `target` directory, there is no need to keep an entry for the `target/classes` directory. Likewise, the `reportDirectory` field is removed because its value (read-only) was identical to `outputDirectory` (also read-only). A side effect of this change is that the following logs, which was previously emitted by the `default` integration test, are now gone:
```
[DEBUG] Skipping non-existing directory (…snip…)/target/it/default/target/classes
[DEBUG] Skipping non-existing directory (…snip…)/target/it/default/target/test-classes
[DEBUG] Skipping non-existing directory (…snip…)/target/it/default/target/classes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete also the directories specified in `` [maven-clean-plugin]
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on PR #276:
URL: https://github.com/apache/maven-clean-plugin/pull/276#issuecomment-3448210808
Added the integration test. Also modified the code for resolving relative paths against `${maven.build.outputDirectory}` (usually `target/classes`), as specified in `maven.mdo`.
Note: this change assumes that https://github.com/apache/maven/pull/11322 is accepted, i.e. that the specification in `maven.mdo` is incomplete and should said that relative paths are rather resolved against `${maven.build.testOutputDirectory}` when the scope is `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete also the directories specified in `` [maven-clean-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #276:
URL: https://github.com/apache/maven-clean-plugin/pull/276#issuecomment-3448705970
@desruisseaux Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete also the directories specified in `` [maven-clean-plugin]
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on PR #276:
URL: https://github.com/apache/maven-clean-plugin/pull/276#issuecomment-3443805238
Oups! Right, I forget that. Will do this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete also the directories specified in `` [maven-clean-plugin]
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux merged PR #276:
URL: https://github.com/apache/maven-clean-plugin/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org