Re: [PR] [feature-wip](merge-on-write) MOW table support different primary keys and sort keys [doris]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #24788:
URL: https://github.com/apache/doris/pull/24788#discussion_r1360080856


##########
be/src/olap/delete_bitmap_calculator.h:
##########
@@ -91,7 +94,7 @@ class MergeIndexDeleteBitmapCalculator {
     MergeIndexDeleteBitmapCalculator() = default;
 
     Status init(RowsetId rowset_id, std::vector<SegmentSharedPtr> const& segments,
-                size_t seq_col_length = 0, size_t max_batch_size = 1024);
+                size_t seq_col_length = 0, size_t rowid_length = 0, size_t max_batch_size = 1024);

Review Comment:
   warning: 1024 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
   ```cpp
                   size_t seq_col_length = 0, size_t rowid_length = 0, size_t max_batch_size = 1024);
                                                                                               ^
   ```
   



##########
be/src/olap/rowset/segment_v2/segment_writer.h:
##########
@@ -153,9 +153,16 @@ class SegmentWriter {
     std::string _full_encode_keys(
             const std::vector<vectorized::IOlapColumnDataAccessor*>& key_columns, size_t pos,
             bool null_first = true);
+
+    std::string _full_encode_keys(
+            std::vector<const KeyCoder*>& key_coders,
+            const std::vector<vectorized::IOlapColumnDataAccessor*>& key_columns, size_t pos,
+            bool null_first = true);
+
     // used for unique-key with merge on write
     void _encode_seq_column(const vectorized::IOlapColumnDataAccessor* seq_column, size_t pos,
                             string* encoded_keys);
+    void _encode_rowid(const uint32_t rowid, string* encoded_keys);

Review Comment:
   warning: parameter 'rowid' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
   
   ```suggestion
       void _encode_rowid(uint32_t rowid, string* encoded_keys);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org