You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2023/11/30 11:35:22 UTC
[PR] [SPARK-XXXX]Properly support error handling and conversion for AddArt… [spark]
grundprinzip opened a new pull request, #44092:
URL: https://github.com/apache/spark/pull/44092
…ifactHandler
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412045885
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
Review Comment:
This function was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412089968
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -128,7 +144,10 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
responseObserver.onNext(builder.build())
responseObserver.onCompleted()
} catch {
- case e: StatusRuntimeException => onError(e)
+ ErrorUtils.handleNonQueryError(
Review Comment:
ErrorUtils.handleError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412038798
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -128,7 +136,7 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
responseObserver.onNext(builder.build())
responseObserver.onCompleted()
} catch {
- case e: StatusRuntimeException => onError(e)
+ ErrorUtils.handleNonQueryError("addArtifact - onNext", responseObserver, Some(this.holder))
Review Comment:
You could have saved yourself a large number of characters by just proposing the last one. Changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "cdkrot (via GitHub)" <gi...@apache.org>.
cdkrot commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1411961472
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
Review Comment:
I think we need some documentation here on what handleSomethingError does and why. I'm also slightly cautious about introducing generic one-size-fits-all-handle-error, because this function can accumulate more users in the future with ever-so-slightly different handling requirements and becoming a big mess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412089622
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -230,7 +249,8 @@ private[connect] object ErrorUtils extends Logging {
userId: String,
sessionId: String,
events: Option[ExecuteEventsManager] = None,
- isInterrupted: Boolean = false): PartialFunction[Throwable, Unit] = {
+ isInterrupted: Boolean = false,
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
Review Comment:
callback is unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "cdkrot (via GitHub)" <gi...@apache.org>.
cdkrot commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1411961472
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
Review Comment:
I think we need some documentation here on what handleSomethingError does and why and how it's separated from original handleError. I'm also slightly cautious about introducing generic one-size-fits-all-handle-error, because this function can accumulate more users in the future with ever-so-slightly different handling requirements and becoming a big mess, unless we document assumptions on what and why this does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412037780
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
+ val partial: PartialFunction[Throwable, Throwable] = {
+ case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
+ StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e, sessionHolderOpt))
+ case e: StatusRuntimeException => e
Review Comment:
In the original query error case, I was very certain that the error conversion does not happen inside the try block. Let me research why I added this (or if I was just cautious)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093]Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on PR #44092:
URL: https://github.com/apache/spark/pull/44092#issuecomment-1834544064
@hvanhovell @HyukjinKwon PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "cdkrot (via GitHub)" <gi...@apache.org>.
cdkrot commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1411961472
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
Review Comment:
I think we need some documentation here on what handleSomethingError does and why and how it's separated from original handleError. I'm also slightly cautious about introducing generic one-size-fits-all-handle-error, because this function can accumulate more users in the future with ever-so-slightly different handling requirements and becoming a big mess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44092: [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler
URL: https://github.com/apache/spark/pull/44092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44092:
URL: https://github.com/apache/spark/pull/44092#issuecomment-1834993358
cc @cdkrot @heyihong mind taking a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1411953279
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
+ val partial: PartialFunction[Throwable, Throwable] = {
+ case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
+ StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e, sessionHolderOpt))
+ case e: StatusRuntimeException => e
Review Comment:
this case is not present in the query `handleError`, why it's a case needed here?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -128,7 +136,7 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
responseObserver.onNext(builder.build())
responseObserver.onCompleted()
} catch {
- case e: StatusRuntimeException => onError(e)
+ ErrorUtils.handleNonQueryError("addArtifact - onNext", responseObserver, Some(this.holder))
Review Comment:
nit: should this op name be "addArtifact - onCompleted"?
nit2: the RPC is named "addArtifacts"; should we use opname "addArtifacts"?
nit3: maybe "addArtifacts.onNext" / "addArtifacts.onCompleted"? I somehow find the " - " separator weird.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
Review Comment:
does this need to be a separate function from `handleError`, or could the "callback" be called into the previous function?
At a glance `handleError` seems to be a compatible superset of functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412088066
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -78,6 +78,22 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
} else {
throw new UnsupportedOperationException(s"Unsupported data transfer request: $req")
}
+ } catch {
+ ErrorUtils.handleError(
Review Comment:
We need to include cleanUpStagedArtifacts callback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412045625
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -213,6 +221,30 @@ private[connect] object ErrorUtils extends Logging {
.exists(_.toString.contains("org.apache.spark.sql.execution.python"))
}
+ def handleNonQueryError[V](
+ opName: String,
+ observer: StreamObserver[V],
+ sessionHolderOpt: Option[SessionHolder],
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
Review Comment:
You're actually right, all the information is already present in the holder, removed this function and called the other one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44092:
URL: https://github.com/apache/spark/pull/44092#issuecomment-1837634916
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412135594
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -230,7 +249,8 @@ private[connect] object ErrorUtils extends Logging {
userId: String,
sessionId: String,
events: Option[ExecuteEventsManager] = None,
- isInterrupted: Boolean = false): PartialFunction[Throwable, Unit] = {
+ isInterrupted: Boolean = false,
+ callback: Option[() => Unit] = None): PartialFunction[Throwable, Unit] = {
Review Comment:
yeah, too early push
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -128,7 +144,10 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
responseObserver.onNext(builder.build())
responseObserver.onCompleted()
} catch {
- case e: StatusRuntimeException => onError(e)
+ ErrorUtils.handleNonQueryError(
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45093][CONNECT][PYTHON] Properly support error handling and conversion for AddArtifactHandler [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #44092:
URL: https://github.com/apache/spark/pull/44092#discussion_r1412088066
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -78,6 +78,22 @@ class SparkConnectAddArtifactsHandler(val responseObserver: StreamObserver[AddAr
} else {
throw new UnsupportedOperationException(s"Unsupported data transfer request: $req")
}
+ } catch {
+ ErrorUtils.handleError(
Review Comment:
We need to include cleanUpStagedArtifacts callback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org