You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/19 07:36:01 UTC
[GitHub] [lucene-solr] tboeghk opened a new pull request #1595: SOLR-10059: Workaround for re-appended query params
tboeghk opened a new pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595
# Description
This is a small yet simple fix for [SOLR-10059](https://issues.apache.org/jira/browse/SOLR-10059) to remove the re-appending of query params in the `SearchHandler` `appends` section on shards in a distributed request.
# Solution
The patch skips re-appending on the shards (`isShard=true`) if the parameter `shards.handler.skipAppends=true`. The latter defaults to `false`.
The fix is built against the `branch_7x` branch. I'll also check for `master` branch.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tboeghk commented on pull request #1595: SOLR-10059: Workaround for re-appended query params
Posted by GitBox <gi...@apache.org>.
tboeghk commented on pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595#issuecomment-854428675
Super seeded by https://github.com/apache/solr/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tboeghk commented on pull request #1595: SOLR-10059: Workaround for re-appended query params
Posted by GitBox <gi...@apache.org>.
tboeghk commented on pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595#issuecomment-854428675
Super seeded by https://github.com/apache/solr/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tboeghk closed pull request #1595: SOLR-10059: Workaround for re-appended query params
Posted by GitBox <gi...@apache.org>.
tboeghk closed pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tboeghk closed pull request #1595: SOLR-10059: Workaround for re-appended query params
Posted by GitBox <gi...@apache.org>.
tboeghk closed pull request #1595:
URL: https://github.com/apache/lucene-solr/pull/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org