You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/01/22 09:07:39 UTC
[GitHub] incubator-rocketmq pull request #48: [ROCKETMQ-70] Duplicate methods in Nett...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/48
[ROCKETMQ-70] Duplicate methods in NettyRemotingClient
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-70
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1
Author: shroman <rs...@yahoo.com>
Date: 2017-01-22T09:07:14Z
[ROCKETMQ-70] Duplicate methods in NettyRemotingClient
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-70
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #48: [ROCKETMQ-70] Duplicate methods in NettyRemoti...
Posted by lollipopjin <gi...@git.apache.org>.
Github user lollipopjin commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
Done with the review work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #48: [ROCKETMQ-70] Duplicate methods in NettyRemoti...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
Simply removal of duplicate methods. Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #48: [ROCKETMQ-70] Duplicate methods in NettyRemoti...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
[](https://coveralls.io/builds/9785769)
Coverage decreased (-0.06%) to 26.245% when pulling **e14c18c04f8f2aafdf3ce9acc9fbbe4bdca7a8d1 on shroman:ROCKETMQ-70** into **881aef5d3195b918c87043ea75a19a3fb805b2e0 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #48: [ROCKETMQ-70] Duplicate methods in NettyRemoti...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/48
alright
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #48: [ROCKETMQ-70] Duplicate methods in Nett...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---