You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/25 02:47:07 UTC
[GitHub] [iotdb] jun0315 opened a new pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
jun0315 opened a new pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460
see https://issues.apache.org/jira/browse/IOTDB-1901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44621825)
Coverage increased (+0.05%) to 67.318% when pulling **6886f4acdae4f53d763a334cc03b28093dd76600 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762682381
##########
File path: server/src/main/java/org/apache/iotdb/db/protocol/influxdb/dto/IoTDBPoint.java
##########
@@ -62,4 +68,14 @@ public long getTime() {
public List<Object> getValues() {
return values;
}
+
+ public InsertRowPlan cvtToInsertRowPlan()
Review comment:
```suggestion
public InsertRowPlan convertToInsertRowPlan()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762684287
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/handler/InfluxDBServiceThriftHandler.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.service.thrift.handler;
+
+import org.apache.iotdb.db.service.thrift.impl.InfluxDBServiceImpl;
+
+import org.apache.thrift.protocol.TProtocol;
+import org.apache.thrift.server.ServerContext;
+import org.apache.thrift.server.TServerEventHandler;
+import org.apache.thrift.transport.TTransport;
+
+public class InfluxDBServiceThriftHandler implements TServerEventHandler {
+ private final InfluxDBServiceImpl influxDBServiceImpl;
+
+ public InfluxDBServiceThriftHandler(InfluxDBServiceImpl influxDBServiceImpl) {
+ this.influxDBServiceImpl = influxDBServiceImpl;
+ }
+
+ @Override
+ public void preServe() {
+ // nothing
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44771837)
Coverage decreased (-0.02%) to 67.287% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44532160)
Coverage decreased (-0.02%) to 67.248% when pulling **93ed7e73403f4c0c931c8cf95711b3fddda1fbcd on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44778359)
Coverage decreased (-0.07%) to 67.243% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762681293
##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -760,6 +767,12 @@
*/
private boolean enableRpcService = true;
+ /**
+ * whether enable the influxdb rpc service. This parameter has no a corresponding field in the
+ * iotdb-engine.properties
+ */
+ private boolean enableInfluxDBRpcService = true;
Review comment:
```suggestion
private boolean enableInfluxDBRpcService = false;
```
Set the property false by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762679863
##########
File path: influxdb-protocol/src/main/java/org/apache/iotdb/influxdb/session/InfluxDBSession.java
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.influxdb.session;
+
+import org.apache.iotdb.db.conf.IoTDBDescriptor;
+import org.apache.iotdb.protocol.influxdb.rpc.thrift.*;
+import org.apache.iotdb.rpc.IoTDBConnectionException;
+import org.apache.iotdb.rpc.RpcTransportFactory;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.rpc.StatementExecutionException;
+import org.apache.iotdb.session.Config;
+
+import org.apache.thrift.TException;
+import org.apache.thrift.protocol.TBinaryProtocol;
+import org.apache.thrift.protocol.TCompactProtocol;
+import org.apache.thrift.transport.TTransport;
+import org.apache.thrift.transport.TTransportException;
+import org.influxdb.InfluxDBException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import static org.apache.iotdb.session.SessionConnection.MSG_RECONNECTION_FAIL;
+
+public class InfluxDBSession {
+ private static final Logger logger = LoggerFactory.getLogger(InfluxDBSession.class);
+
+ private TTransport transport;
+ private InfluxDBService.Iface client;
+ private List<EndPoint> endPointList = new ArrayList<>();
+ private long sessionId;
+
+ protected String username;
+ protected String password;
+ protected int fetchSize;
+ protected ZoneId zoneId;
+ protected EndPoint defaultEndPoint;
+ protected int thriftDefaultBufferSize;
+ protected int thriftMaxFrameSize;
+
+ private boolean isClosed = true;
+ protected boolean enableRPCCompression;
+ protected int connectionTimeoutInMs;
+
+ public InfluxDBSession(String host, int rpcPort, String username, String password) {
+ this(
+ host,
+ rpcPort,
+ username,
+ password,
+ Config.DEFAULT_FETCH_SIZE,
+ ZoneId.systemDefault(),
+ Config.DEFAULT_INITIAL_BUFFER_CAPACITY,
+ Config.DEFAULT_MAX_FRAME_SIZE);
+ }
+
+ public InfluxDBSession(
+ String host,
+ int rpcPort,
+ String username,
+ String password,
+ int fetchSize,
+ ZoneId zoneId,
+ int thriftDefaultBufferSize,
+ int thriftMaxFrameSize) {
+ this.defaultEndPoint = new EndPoint(host, rpcPort);
+ this.username = username;
+ this.password = password;
+ this.fetchSize = fetchSize;
+ this.zoneId = zoneId;
+ this.thriftDefaultBufferSize = thriftDefaultBufferSize;
+ this.thriftMaxFrameSize = thriftMaxFrameSize;
+ }
+
+ public synchronized void open() throws IoTDBConnectionException {
+ open(false, Config.DEFAULT_CONNECTION_TIMEOUT_MS);
+ }
+
+ public synchronized void open(boolean enableRPCCompression, int connectionTimeoutInMs)
+ throws IoTDBConnectionException {
+ if (!isClosed) {
+ return;
+ }
+ this.enableRPCCompression = enableRPCCompression;
+ this.connectionTimeoutInMs = connectionTimeoutInMs;
+ this.endPointList.add(defaultEndPoint);
+
+ init();
+ isClosed = false;
+ }
+
+ public void init() throws IoTDBConnectionException {
+ RpcTransportFactory.setDefaultBufferCapacity(thriftDefaultBufferSize);
+ RpcTransportFactory.setThriftMaxFrameSize(thriftMaxFrameSize);
+ try {
+ transport =
+ RpcTransportFactory.INSTANCE.getTransport(
+ // as there is a try-catch already, we do not need to use TSocket.wrap
+ defaultEndPoint.getIp(), defaultEndPoint.getPort(), connectionTimeoutInMs);
+ transport.open();
+ } catch (TTransportException e) {
+ throw new IoTDBConnectionException(e);
+ }
+
+ if (IoTDBDescriptor.getInstance().getConfig().isRpcThriftCompressionEnable()) {
+ client = new InfluxDBService.Client(new TCompactProtocol(transport));
+ } else {
+ client = new InfluxDBService.Client(new TBinaryProtocol(transport));
+ }
+ client = RpcUtils.newSynchronizedClient(client);
+
+ TSOpenSessionReq openReq = new TSOpenSessionReq();
+ openReq.setUsername(username);
+ openReq.setPassword(password);
+ openReq.setZoneId(zoneId.toString());
+
+ try {
+ TSOpenSessionResp openResp = client.openSession(openReq);
+
+ sessionId = openResp.getSessionId();
+
+ } catch (Exception e) {
+ transport.close();
+ throw new IoTDBConnectionException(e);
+ }
+ System.out.println(sessionId);
+ }
+
+ public void writePoints(TSWritePointsReq request)
+ throws StatementExecutionException, IoTDBConnectionException {
+ request.setSessionId(sessionId);
+ try {
+ RpcUtils.verifySuccess(client.writePoints(request));
+ } catch (TException e) {
+ logger.error(e.getMessage());
+ if (reconnect()) {
+ try {
+ request.setSessionId(sessionId);
+ RpcUtils.verifySuccess(client.writePoints(request));
+ } catch (TException tException) {
+ throw new IoTDBConnectionException(tException);
+ }
+ } else {
+ throw new IoTDBConnectionException(MSG_RECONNECTION_FAIL);
+ }
+ }
+ }
+
+ public void createDatabase(TSCreateDatabaseReq request)
+ throws StatementExecutionException, IoTDBConnectionException {
+ request.setSessionId(sessionId);
+ try {
+ RpcUtils.verifySuccess(client.createDatabase(request));
+ } catch (TException e) {
+ e.printStackTrace();
+ logger.error(e.getMessage());
+ if (reconnect()) {
+ try {
+ request.setSessionId(sessionId);
+ RpcUtils.verifySuccess(client.createDatabase(request));
+ } catch (TException tException) {
+ throw new IoTDBConnectionException(tException);
+ }
+ } else {
+ throw new IoTDBConnectionException(MSG_RECONNECTION_FAIL);
+ }
+ }
+ }
+
+ public void close() {
+ TSCloseSessionReq req = new TSCloseSessionReq(sessionId);
+ try {
+ client.closeSession(req);
+ } catch (TException e) {
+ throw new InfluxDBException(
+ "Error occurs when closing session at server. Maybe server is down.", e);
+ } finally {
+ if (isClosed) return;
Review comment:
```suggestion
if (isClosed) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44587448)
Coverage increased (+0.05%) to 67.324% when pulling **a35f73bfffe3cdccc88d41ff6cc32c3caa8c920d on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772077)
Coverage decreased (-0.03%) to 67.285% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772322)
Coverage decreased (-0.007%) to 67.304% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762779265
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/InfluxDBServiceImpl.java
##########
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.service.thrift.impl;
+
+import org.apache.iotdb.db.exception.StorageEngineException;
+import org.apache.iotdb.db.exception.metadata.IllegalPathException;
+import org.apache.iotdb.db.exception.metadata.StorageGroupNotSetException;
+import org.apache.iotdb.db.exception.query.QueryProcessException;
+import org.apache.iotdb.db.metadata.path.PartialPath;
+import org.apache.iotdb.db.protocol.influxdb.dto.IoTDBPoint;
+import org.apache.iotdb.db.protocol.influxdb.input.InfluxLineParser;
+import org.apache.iotdb.db.protocol.influxdb.meta.MetaManager;
+import org.apache.iotdb.db.qp.physical.PhysicalPlan;
+import org.apache.iotdb.db.qp.physical.crud.InsertRowPlan;
+import org.apache.iotdb.db.qp.physical.sys.SetStorageGroupPlan;
+import org.apache.iotdb.db.service.basic.BasicOpenSessionResp;
+import org.apache.iotdb.db.service.basic.BasicServiceProvider;
+import org.apache.iotdb.db.utils.DataTypeUtils;
+import org.apache.iotdb.protocol.influxdb.rpc.thrift.*;
+import org.apache.iotdb.rpc.IoTDBConnectionException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.rpc.TSStatusCode;
+import org.apache.iotdb.service.rpc.thrift.TSProtocolVersion;
+
+import org.apache.thrift.TException;
+import org.influxdb.InfluxDBException;
+import org.influxdb.dto.Point;
+
+public class InfluxDBServiceImpl implements InfluxDBService.Iface {
+
+ private final BasicServiceProvider basicServiceProvider;
+
+ private final MetaManager metaManager;
+
+ public InfluxDBServiceImpl() throws QueryProcessException {
+ basicServiceProvider = new BasicServiceProvider();
+ metaManager = MetaManager.getInstance();
+ }
+
+ @Override
+ public TSOpenSessionResp openSession(TSOpenSessionReq req) throws TException {
+ BasicOpenSessionResp basicOpenSessionResp =
+ basicServiceProvider.openSession(
+ req.username, req.password, req.zoneId, TSProtocolVersion.IOTDB_SERVICE_PROTOCOL_V3);
+ return new TSOpenSessionResp()
+ .setStatus(
+ RpcUtils.getInfluxDBStatus(
+ basicOpenSessionResp.getCode(), basicOpenSessionResp.getMessage()))
+ .setSessionId(basicOpenSessionResp.getSessionId());
+ }
+
+ @Override
+ public TSStatus closeSession(TSCloseSessionReq req) {
+ return new TSStatus(
+ !basicServiceProvider.closeSession(req.sessionId)
+ ? RpcUtils.getInfluxDBStatus(TSStatusCode.NOT_LOGIN_ERROR)
+ : RpcUtils.getInfluxDBStatus(TSStatusCode.SUCCESS_STATUS));
+ }
+
+ @Override
+ public TSStatus writePoints(TSWritePointsReq req) {
+ if (!basicServiceProvider.checkLogin(req.sessionId)) {
+ return getNotLoggedInStatus();
+ }
+
+ for (Point point : InfluxLineParser.parserRecordsToPoints(req.lineProtocol)) {
+ IoTDBPoint iotdbPoint = new IoTDBPoint(req.database, point, metaManager);
+ try {
+ InsertRowPlan plan = iotdbPoint.convertToInsertRowPlan();
+ if (!basicServiceProvider.executeNonQuery(plan)) {
+ return RpcUtils.getInfluxDBStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR);
+ }
+ } catch (StorageGroupNotSetException
+ | StorageEngineException
+ | IllegalPathException
+ | IoTDBConnectionException
+ | QueryProcessException e) {
+ throw new InfluxDBException(e.getMessage());
+ }
+ }
+ return RpcUtils.getInfluxDBStatus(TSStatusCode.SUCCESS_STATUS);
+ }
+
+ @Override
+ public TSStatus createDatabase(TSCreateDatabaseReq req) throws TException {
+ if (!basicServiceProvider.checkLogin(req.sessionId)) {
+ return getNotLoggedInStatus();
+ }
+
+ try {
+ SetStorageGroupPlan setStorageGroupPlan =
+ new SetStorageGroupPlan(new PartialPath("root." + req.getDatabase()));
+ return executeNonQueryPlan(setStorageGroupPlan, req.getSessionId());
+ } catch (IllegalPathException
+ | QueryProcessException
+ | StorageGroupNotSetException
+ | StorageEngineException e) {
+ if (e instanceof QueryProcessException && e.getErrorCode() == 300) {
+ return RpcUtils.getInfluxDBStatus(
+ TSStatusCode.SUCCESS_STATUS.getStatusCode(), "Execute successfully");
+ }
+ throw new InfluxDBException(e.getMessage());
+ }
+ }
+
+ public void handleClientExit() {
+ Long sessionId = BasicServiceProvider.sessionManager.getCurrSessionId();
+ if (sessionId != null) {
+ TSCloseSessionReq req = new TSCloseSessionReq(sessionId);
+ closeSession(req);
Review comment:
```suggestion
closeSession(new TSCloseSessionReq(sessionId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44778025)
Coverage decreased (-0.08%) to 67.228% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44543232)
Coverage increased (+0.05%) to 67.32% when pulling **106cda76b73d194b482a58a0e9f6a4bd1825edd1 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44587475)
Coverage increased (+0.05%) to 67.325% when pulling **a35f73bfffe3cdccc88d41ff6cc32c3caa8c920d on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44587182)
Coverage increased (+0.06%) to 67.332% when pulling **a35f73bfffe3cdccc88d41ff6cc32c3caa8c920d on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762679625
##########
File path: influxdb-protocol/src/main/java/org/apache/iotdb/influxdb/session/InfluxDBSession.java
##########
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.influxdb.session;
+
+import org.apache.iotdb.db.conf.IoTDBDescriptor;
+import org.apache.iotdb.protocol.influxdb.rpc.thrift.*;
+import org.apache.iotdb.rpc.IoTDBConnectionException;
+import org.apache.iotdb.rpc.RpcTransportFactory;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.rpc.StatementExecutionException;
+import org.apache.iotdb.session.Config;
+
+import org.apache.thrift.TException;
+import org.apache.thrift.protocol.TBinaryProtocol;
+import org.apache.thrift.protocol.TCompactProtocol;
+import org.apache.thrift.transport.TTransport;
+import org.apache.thrift.transport.TTransportException;
+import org.influxdb.InfluxDBException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import static org.apache.iotdb.session.SessionConnection.MSG_RECONNECTION_FAIL;
+
+public class InfluxDBSession {
+ private static final Logger logger = LoggerFactory.getLogger(InfluxDBSession.class);
+
+ private TTransport transport;
+ private InfluxDBService.Iface client;
+ private List<EndPoint> endPointList = new ArrayList<>();
+ private long sessionId;
+
+ protected String username;
+ protected String password;
+ protected int fetchSize;
+ protected ZoneId zoneId;
+ protected EndPoint defaultEndPoint;
+ protected int thriftDefaultBufferSize;
+ protected int thriftMaxFrameSize;
+
+ private boolean isClosed = true;
+ protected boolean enableRPCCompression;
+ protected int connectionTimeoutInMs;
+
+ public InfluxDBSession(String host, int rpcPort, String username, String password) {
+ this(
+ host,
+ rpcPort,
+ username,
+ password,
+ Config.DEFAULT_FETCH_SIZE,
+ ZoneId.systemDefault(),
+ Config.DEFAULT_INITIAL_BUFFER_CAPACITY,
+ Config.DEFAULT_MAX_FRAME_SIZE);
+ }
+
+ public InfluxDBSession(
+ String host,
+ int rpcPort,
+ String username,
+ String password,
+ int fetchSize,
+ ZoneId zoneId,
+ int thriftDefaultBufferSize,
+ int thriftMaxFrameSize) {
+ this.defaultEndPoint = new EndPoint(host, rpcPort);
+ this.username = username;
+ this.password = password;
+ this.fetchSize = fetchSize;
+ this.zoneId = zoneId;
+ this.thriftDefaultBufferSize = thriftDefaultBufferSize;
+ this.thriftMaxFrameSize = thriftMaxFrameSize;
+ }
+
+ public synchronized void open() throws IoTDBConnectionException {
+ open(false, Config.DEFAULT_CONNECTION_TIMEOUT_MS);
+ }
+
+ public synchronized void open(boolean enableRPCCompression, int connectionTimeoutInMs)
+ throws IoTDBConnectionException {
+ if (!isClosed) {
+ return;
+ }
+ this.enableRPCCompression = enableRPCCompression;
+ this.connectionTimeoutInMs = connectionTimeoutInMs;
+ this.endPointList.add(defaultEndPoint);
+
+ init();
+ isClosed = false;
+ }
+
+ public void init() throws IoTDBConnectionException {
+ RpcTransportFactory.setDefaultBufferCapacity(thriftDefaultBufferSize);
+ RpcTransportFactory.setThriftMaxFrameSize(thriftMaxFrameSize);
+ try {
+ transport =
+ RpcTransportFactory.INSTANCE.getTransport(
+ // as there is a try-catch already, we do not need to use TSocket.wrap
+ defaultEndPoint.getIp(), defaultEndPoint.getPort(), connectionTimeoutInMs);
+ transport.open();
+ } catch (TTransportException e) {
+ throw new IoTDBConnectionException(e);
+ }
+
+ if (IoTDBDescriptor.getInstance().getConfig().isRpcThriftCompressionEnable()) {
+ client = new InfluxDBService.Client(new TCompactProtocol(transport));
+ } else {
+ client = new InfluxDBService.Client(new TBinaryProtocol(transport));
+ }
+ client = RpcUtils.newSynchronizedClient(client);
+
+ TSOpenSessionReq openReq = new TSOpenSessionReq();
+ openReq.setUsername(username);
+ openReq.setPassword(password);
+ openReq.setZoneId(zoneId.toString());
+
+ try {
+ TSOpenSessionResp openResp = client.openSession(openReq);
+
+ sessionId = openResp.getSessionId();
+
+ } catch (Exception e) {
+ transport.close();
+ throw new IoTDBConnectionException(e);
+ }
+ System.out.println(sessionId);
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762781009
##########
File path: server/src/main/java/org/apache/iotdb/db/protocol/influxdb/meta/TagInfoRecords.java
##########
@@ -75,11 +77,21 @@ public void add(String database, String measurement, String tag, int order) {
valuesList.add(values);
}
- public void persist(Session session) {
- try {
- session.insertRecords(deviceIds, times, measurementsList, typesList, valuesList);
- } catch (IoTDBConnectionException | StatementExecutionException e) {
- throw new InfluxDBException(e.getMessage());
+ public List<InsertRowPlan> cvtToInsertRowPlans() {
Review comment:
```suggestion
public List<InsertRowPlan> convertToInsertRowPlans() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44623368)
Coverage increased (+0.07%) to 67.337% when pulling **2dd85f210e20412ce09e62234761bd59009cdb3a on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44780307)
Coverage decreased (-0.07%) to 67.243% when pulling **057a0a34adb7ab8088b99e60b99a2d8dcb4a8fa4 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44594923)
Coverage increased (+0.05%) to 67.318% when pulling **b1b9bb020fa795d714ba0b8b3ce0d5d994dccc1f on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44594934)
Coverage increased (+0.05%) to 67.32% when pulling **b1b9bb020fa795d714ba0b8b3ce0d5d994dccc1f on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44631994)
Coverage decreased (-0.01%) to 67.305% when pulling **6aa54c7fcf1b7a145cdd1ab87873df55187f83de on jun0315:influxdb-server-side-metadata** into **4f8015ce528782f8ed59f276c56af91659267c5b on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#discussion_r762680192
##########
File path: influxdb-protocol/src/test/java/org/apache/iotdb/influxdb/integration/IoTDBInfluxDBIT.java
##########
@@ -53,12 +54,12 @@
@Rule
public GenericContainer<?> iotdb =
- new GenericContainer<>("apache/iotdb:latest").withExposedPorts(6667);
+ new GenericContainer(DockerImageName.parse("apache/iotdb:maven-development")).withExposedPorts(6667);
Review comment:
```suggestion
new GenericContainer(DockerImageName.parse("apache/iotdb:maven-development")).withExposedPorts(8086);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44777574)
Coverage decreased (-0.08%) to 67.229% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44778105)
Coverage decreased (-0.08%) to 67.234% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44582736)
Coverage increased (+0.06%) to 67.327% when pulling **e925050aa37b1540cafa5454f95039dd6e3e886c on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44595305)
Coverage increased (+0.05%) to 67.326% when pulling **b1b9bb020fa795d714ba0b8b3ce0d5d994dccc1f on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44532224)
Coverage decreased (-0.07%) to 67.199% when pulling **8f46d54d66c87aeee4f3efd851629f6f78e442f1 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44777555)
Coverage decreased (-0.08%) to 67.235% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44778913)
Coverage decreased (-0.07%) to 67.239% when pulling **05dc8e2b5ef2ef89c5d216f433a90a7f0e5e60ea on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772681)
Coverage decreased (-0.06%) to 67.254% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44776818)
Coverage decreased (-0.08%) to 67.228% when pulling **252205b3f01ba94b7554c6348aa5686e2958c690 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772259)
Coverage decreased (-0.009%) to 67.301% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772633)
Coverage decreased (-0.02%) to 67.293% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772490)
Coverage decreased (-0.03%) to 67.281% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44778825)
Coverage decreased (-0.08%) to 67.233% when pulling **05dc8e2b5ef2ef89c5d216f433a90a7f0e5e60ea on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44532725)
Coverage decreased (-0.07%) to 67.198% when pulling **8f46d54d66c87aeee4f3efd851629f6f78e442f1 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44582759)
Coverage increased (+0.08%) to 67.349% when pulling **e925050aa37b1540cafa5454f95039dd6e3e886c on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44538549)
Coverage increased (+0.03%) to 67.298% when pulling **5443e41c2e88748e3fb86034b04932ccf02e6ea5 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44532400)
Coverage decreased (-0.03%) to 67.242% when pulling **8f46d54d66c87aeee4f3efd851629f6f78e442f1 on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44587258)
Coverage increased (+0.09%) to 67.356% when pulling **a35f73bfffe3cdccc88d41ff6cc32c3caa8c920d on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44599495)
Coverage increased (+0.07%) to 67.344% when pulling **dc1d12d08a82829b36999444f49c633e47480f0b on jun0315:influxdb-server-side-metadata** into **1f853f155ed401fc95cd57ec44cfeaaffc14f54f on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44772213)
Coverage increased (+0.008%) to 67.318% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44781060)
Coverage decreased (-0.07%) to 67.239% when pulling **057a0a34adb7ab8088b99e60b99a2d8dcb4a8fa4 on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4460: [IOTDB-1901] Compatibility of Apache IoTDB with InfluxDB - Server-side InfluxDB Metadata Manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4460:
URL: https://github.com/apache/iotdb/pull/4460#issuecomment-978792991
[](https://coveralls.io/builds/44771956)
Coverage decreased (-0.03%) to 67.283% when pulling **c07f01debc81e6257c815c03c71bf33386eea11e on jun0315:influxdb-server-side-metadata** into **31548f49dcc6f1d0057c88093089649572cd2680 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org