You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vahmed-hamdy (via GitHub)" <gi...@apache.org> on 2024/11/02 20:07:53 UTC
[PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
vahmed-hamdy opened a new pull request, #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110
## Changelog
- Changed base flink version to 1.20.0
- Removed CI tests for 1.18, 1.19.
- Fixed incompatibility in IT tests TestMailbox.
Successful run:
https://github.com/vahmed-hamdy/flink-connector-elasticsearch/actions/runs/11645464636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#issuecomment-2457790813
@snuyanzin yeah, I guess we can update the arch rules separately, could you please rereun the CI and check now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826875932
##########
flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java:
##########
@@ -496,6 +496,19 @@ public void execute(
}
}
+ @Override
+ public void execute(
Review Comment:
@vahmed-hamdy you may apply the same change as we did for OpenSearch [1], so to be complaint with 1.20/1.19/1.18
[1] https://github.com/apache/flink-connector-opensearch/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#issuecomment-2460195120
@dannycranmer do you see anything else that could be improved here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826960749
##########
flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java:
##########
@@ -496,6 +496,19 @@ public void execute(
}
}
+ @Override
+ public void execute(
Review Comment:
@reta thanks for the hint, PR updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827409670
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
yeah, I agree, I will remove 1.18.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827410038
##########
.github/workflows/weekly.yml:
##########
@@ -30,23 +30,20 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
+ }, {
+ flink: 1.20.0,
+ jdk: '8, 11, 17, 21',
Review Comment:
```suggestion
```
since flink now is 19+ we could remove it from here
and put below
```
jdk_version: ${{ matrix.flink_branches.jdk || '8, 11, 17, 21' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827400830
##########
.github/workflows/weekly.yml:
##########
@@ -30,10 +30,6 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
Review Comment:
I think we should remove the 1.18.1 below and add 1.20.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827466774
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
@snuyanzin Since we are here, is there a reason we are running PR CI tests against snapshot versions, should we replace them with `1.19.1` and `1.20.0` ?
after all we want to test new changes to connector against supporting versions, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827466774
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
@snuyanzin Since we are here, is there a reason we are running PR CI tests against snapshot versions, should we replace them with `1.19.1` and `1.20.0` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827456687
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
I think similar story
since now java is same for all it could be replaced with
```
flink: [ 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
jdk: [ '8, 11, 17, 21' ]
```
and we could completely remove everything under `include:` and `include:` itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826999592
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
Sure, 1.18 could be gone I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827507107
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
I see, thanks for the info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826998011
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
I think it is not mandatory unless we are removing support to the v3.0 branch as explained in the [bylaws](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=231116690#ExternalizedConnectordevelopment-Support) which also couldn't happen until the next connector release.
The ideal case would be to keep the compatibility guarantee with 1.19 as mentioned however I would prefer dropping 1.18 in either cases, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826875932
##########
flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java:
##########
@@ -496,6 +496,19 @@ public void execute(
}
}
+ @Override
+ public void execute(
Review Comment:
@vahmed-hamdy you may apply the same change as we did for OpenSearch [1], so to be complaint with 1.20/1.19/1.18/1.17.
[1] https://github.com/apache/flink-connector-opensearch/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#issuecomment-2478618348
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826981792
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
I think you could bring back 1.19 and 1.18: the tests would compile now (the connectors should support at least one previous release if I am not mistaken, @snuyanzin please correct me here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827487481
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
IIRC it allows to catch breaking changes faster before they released instead of waiting for the release and then receive a bunch of failures
I remember it allowed to catch already several things like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827456687
##########
.github/workflows/push_pr.yml:
##########
@@ -28,11 +28,9 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
- jdk: [ '8, 11, 17' ]
+ flink: [ 1.19-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
include:
- - flink: 1.19-SNAPSHOT
- jdk: '8, 11, 17, 21'
- flink: 1.20-SNAPSHOT
jdk: '8, 11, 17, 21'
Review Comment:
Last bit from my side
I think similar story
since now java is same for all it could be replaced with
```
flink: [ 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
jdk: [ '8, 11, 17, 21' ]
```
and we could completely remove everything under `include:` and `include:` itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#issuecomment-2453113849
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827410038
##########
.github/workflows/weekly.yml:
##########
@@ -30,23 +30,20 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
+ }, {
+ flink: 1.20.0,
+ jdk: '8, 11, 17, 21',
Review Comment:
```suggestion
```
since flink now is 19+ we could remove it from here and other places
and put below
```
jdk_version: ${{ matrix.flink_branches.jdk || '8, 11, 17, 21' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#issuecomment-2455711379
oops seems something wrong with archunit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827059555
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
if we remove 1.18-SNAPSHOT then I don't see a reason to keep 1.18.1 there...
also I think it would make sense to add 1.20.0
WDYT @vahmed-hamdy ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827059555
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
if we remove 1.18-SNAPSHOT then I don't see a reason to keep 1.18.1 there...
also I think it would make sense to 1.20.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827022914
##########
.github/workflows/push_pr.yml:
##########
@@ -28,13 +28,8 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.18-SNAPSHOT ]
Review Comment:
Done ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.19 and 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #110:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1827431349
##########
.github/workflows/weekly.yml:
##########
@@ -30,23 +30,20 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
+ }, {
+ flink: 1.20.0,
+ jdk: '8, 11, 17, 21',
Review Comment:
nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org