You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/28 15:36:37 UTC
Review Request 46762: Enabled volume support for mesos-execute.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46762/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5265
https://issues.apache.org/jira/browse/MESOS-5265
Repository: mesos
Description
-------
Enabled volume support for mesos-execute.
Diffs
-----
src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
Diff: https://reviews.apache.org/r/46762/diff/
Testing
-------
root@mesos002:~/src/mesos/m3/mesos/build# cat /root/test/volume4.json
[{
"container_path":"\/tmp\/abc1",
"mode":"RW",
"source":
{
"docker_volume":
{
"driver":"convoy",
"name":"dvd1"
},
"type":"DOCKER_VOLUME"
}
},
{
"container_path":"\/tmp\/abc2",
"mode":"RW",
"source":
{
"docker_volume":
{
"driver":"convoy",
"driver_options":
{"parameter":[
{
"key":"iops",
"value":"150"
}
]},
"name":"dvd2"
},
"type":"DOCKER_VOLUME"
}
}]
root@mesos002:~/src/mesos/m3/mesos/build# src/mesos-execute --master=192.168.56.12:5050 --name=test --command="sleep 1000000" --volumes=/root/test/volume4.json
I0428 21:27:52.406168 3775 scheduler.cpp:177] Version: 0.29.0
Subscribed with ID '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-0003'
Submitted task 'test' to agent '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-S0'
Received status update TASK_RUNNING for task 'test'
source: SOURCE_EXECUTOR
Thanks,
Guangya Liu
Re: Review Request 46762: Enabled volume support for mesos-execute.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46762/#review130920
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46762]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 28, 2016, 1:56 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46762/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:56 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5265
> https://issues.apache.org/jira/browse/MESOS-5265
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled volume support for mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
>
> Diff: https://reviews.apache.org/r/46762/diff/
>
>
> Testing
> -------
>
> root@mesos002:~/src/mesos/m3/mesos/build# cat /root/test/volume4.json
> [{
> "container_path":"\/tmp\/abc1",
> "mode":"RW",
> "source":
> {
> "docker_volume":
> {
> "driver":"convoy",
> "name":"dvd1"
> },
> "type":"DOCKER_VOLUME"
> }
> },
> {
> "container_path":"\/tmp\/abc2",
> "mode":"RW",
> "source":
> {
> "docker_volume":
> {
> "driver":"convoy",
> "driver_options":
> {"parameter":[
> {
> "key":"iops",
> "value":"150"
> }
> ]},
> "name":"dvd2"
> },
> "type":"DOCKER_VOLUME"
> }
> }]
>
> root@mesos002:~/src/mesos/m3/mesos/build# src/mesos-execute --master=192.168.56.12:5050 --name=test --command="sleep 1000000" --volumes=/root/test/volume4.json
> I0428 21:27:52.406168 3775 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-0003'
> Submitted task 'test' to agent '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-S0'
> Received status update TASK_RUNNING for task 'test'
> source: SOURCE_EXECUTOR
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46762: Enabled volume support for mesos-execute.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46762/
-----------------------------------------------------------
(Updated 四月 28, 2016, 1:56 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5265
https://issues.apache.org/jira/browse/MESOS-5265
Repository: mesos
Description
-------
Enabled volume support for mesos-execute.
Diffs (updated)
-----
src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
Diff: https://reviews.apache.org/r/46762/diff/
Testing
-------
root@mesos002:~/src/mesos/m3/mesos/build# cat /root/test/volume4.json
[{
"container_path":"\/tmp\/abc1",
"mode":"RW",
"source":
{
"docker_volume":
{
"driver":"convoy",
"name":"dvd1"
},
"type":"DOCKER_VOLUME"
}
},
{
"container_path":"\/tmp\/abc2",
"mode":"RW",
"source":
{
"docker_volume":
{
"driver":"convoy",
"driver_options":
{"parameter":[
{
"key":"iops",
"value":"150"
}
]},
"name":"dvd2"
},
"type":"DOCKER_VOLUME"
}
}]
root@mesos002:~/src/mesos/m3/mesos/build# src/mesos-execute --master=192.168.56.12:5050 --name=test --command="sleep 1000000" --volumes=/root/test/volume4.json
I0428 21:27:52.406168 3775 scheduler.cpp:177] Version: 0.29.0
Subscribed with ID '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-0003'
Submitted task 'test' to agent '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-S0'
Received status update TASK_RUNNING for task 'test'
source: SOURCE_EXECUTOR
Thanks,
Guangya Liu