You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/04/24 11:22:17 UTC
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------
(Updated April 24, 2017, 1:22 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Use a test filter instead of an assert to filter tests that need thread-safety.
Summary (updated)
-----------------
Introduced a filter for test cases that need thread-safety.
Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193
Repository: mesos
Description (updated)
-------
Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933
3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
Diff: https://reviews.apache.org/r/58347/diff/2/
Changes: https://reviews.apache.org/r/58347/diff/1-2/
Testing
-------
libprocess-tests (using automake and CMake with macOS, Linux, Windows)
Thanks,
Jan Schlicht
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review174731
-----------------------------------------------------------
Can you rebase this, please?
- Neil Conway
On April 24, 2017, 11:22 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:22 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
> 3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
> 3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
> 3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933
> 3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
> 3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
> 3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
>
>
> Diff: https://reviews.apache.org/r/58347/diff/2/
>
>
> Testing
> -------
>
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review174734
-----------------------------------------------------------
Also please double-check that this RR builds by itself (applying the patch with fuzziness and compiling doesn't build).
- Neil Conway
On April 24, 2017, 11:22 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:22 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
> 3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
> 3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
> 3rdparty/libprocess/src/tests/main.cpp 6ae772416d6a84427d82f4b25b8b26e100426933
> 3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
> 3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
> 3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
>
>
> Diff: https://reviews.apache.org/r/58347/diff/2/
>
>
> Testing
> -------
>
> libprocess-tests (using automake and CMake with macOS, Linux, Windows)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/#review175177
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On May 15, 2017, 10:25 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58347/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:25 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
> 3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
> 3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
> 3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59
> 3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
> 3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
> 3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
>
>
> Diff: https://reviews.apache.org/r/58347/diff/3/
>
>
> Testing
> -------
>
> tested in https://reviews.apache.org/r/58348/, don't commit without commiting 58348.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------
(Updated May 15, 2017, 12:25 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193
Repository: mesos
Description
-------
Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.
Diffs
-----
3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59
3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
Diff: https://reviews.apache.org/r/58347/diff/3/
Testing (updated)
-------
tested in https://reviews.apache.org/r/58348/, don't commit without commiting 58348.
Thanks,
Jan Schlicht
Re: Review Request 58347: Introduced a filter for test cases that need
thread-safety.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------
(Updated May 15, 2017, 12:24 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193
Repository: mesos
Description
-------
Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de
3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa
3rdparty/libprocess/src/tests/main.cpp 23eead809d1f0ddc9a28f492005ff325701bac59
3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818
Diff: https://reviews.apache.org/r/58347/diff/3/
Changes: https://reviews.apache.org/r/58347/diff/2-3/
Testing (updated)
-------
tested in https://reviews.apache.org/r/58348/
Thanks,
Jan Schlicht