Re: [PR] Fix KVM incremental volume snapshot migration between secondary storages [cloudstack]

["winterhazel (via GitHub)" <gi...@apache.org>]

winterhazel commented on code in PR #12086:
URL: https://github.com/apache/cloudstack/pull/12086#discussion_r3170373731


##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -233,6 +233,9 @@ public interface StorageManager extends StorageService {
             "while adding a new Secondary Storage. If the copy operation fails, the system falls back to downloading the template from the source URL.",
             true, ConfigKey.Scope.Zone, null);
 
+    ConfigKey<Integer> AgentMaxDataMigrationWaitTime = new ConfigKey<>("Advanced", Integer.class, "agent.max.data.migration.wait.time", "3600",

Review Comment:
   It would be nice to have a single configuration for secondary storage template, snapshot and volume migration. Templates, volumes and non-incremental snapshots will use `secstorage.cmd.execution.time.max`, while incremental snapshots will use `agent.max.data.migration.wait.time` with this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org