You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2017/10/19 18:44:51 UTC
kudu git commit: tidy: fix some misc tidy warnings in various files
Repository: kudu
Updated Branches:
refs/heads/master d33075ebc -> 741bdfa41
tidy: fix some misc tidy warnings in various files
These warnings came up in an unrelated patch, so figured I'd address
them with a small commit. Nothing of note - mostly unused parameters and
redundant casts.
Change-Id: I91cf2ebfa53a166e9e65982542d46c0bf11d642a
Reviewed-on: http://gerrit.cloudera.org:8080/8293
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/741bdfa4
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/741bdfa4
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/741bdfa4
Branch: refs/heads/master
Commit: 741bdfa415c5ca11b5bb973b7fba4697a278e4d8
Parents: d33075e
Author: Todd Lipcon <to...@apache.org>
Authored: Mon Oct 16 22:48:25 2017 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Thu Oct 19 18:44:36 2017 +0000
----------------------------------------------------------------------
src/kudu/common/scan_spec-test.cc | 5 ++---
src/kudu/tablet/mt-tablet-test.cc | 2 +-
src/kudu/tablet/tablet-decoder-eval-test.cc | 4 ++--
src/kudu/tserver/tablet_server-test-base.cc | 7 ++++---
src/kudu/tserver/tablet_service.cc | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/741bdfa4/src/kudu/common/scan_spec-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/scan_spec-test.cc b/src/kudu/common/scan_spec-test.cc
index a27a8df..9547b30 100644
--- a/src/kudu/common/scan_spec-test.cc
+++ b/src/kudu/common/scan_spec-test.cc
@@ -52,9 +52,8 @@ class TestScanSpec : public KuduTest {
public:
explicit TestScanSpec(const Schema& s)
: arena_(1024),
- pool_(),
- schema_(s),
- spec_() {}
+ schema_(s) {
+ }
enum ComparisonOp {
GE,
http://git-wip-us.apache.org/repos/asf/kudu/blob/741bdfa4/src/kudu/tablet/mt-tablet-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/mt-tablet-test.cc b/src/kudu/tablet/mt-tablet-test.cc
index 780d3d9..771f78e 100644
--- a/src/kudu/tablet/mt-tablet-test.cc
+++ b/src/kudu/tablet/mt-tablet-test.cc
@@ -210,7 +210,7 @@ class MultiThreadedTabletTest : public TabletTestBase<SETUP> {
// Thread which iterates slowly over the first 10% of the data.
// This is meant to test that outstanding iterators don't end up
// trying to reference already-freed memrowset memory.
- void SlowReaderThread(int tid) {
+ void SlowReaderThread(int /*tid*/) {
Arena arena(32*1024);
RowBlock block(schema_, 1, &arena);
http://git-wip-us.apache.org/repos/asf/kudu/blob/741bdfa4/src/kudu/tablet/tablet-decoder-eval-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet-decoder-eval-test.cc b/src/kudu/tablet/tablet-decoder-eval-test.cc
index c49c969..ed1a482 100644
--- a/src/kudu/tablet/tablet-decoder-eval-test.cc
+++ b/src/kudu/tablet/tablet-decoder-eval-test.cc
@@ -115,7 +115,7 @@ public:
}
for (int i = 0; i < FLAGS_decoder_eval_test_nrepeats; i++) {
- TestTimedScanWithBounds(nrows, cardinality, strlen, lower, upper, &fetched);
+ TestTimedScanWithBounds(strlen, lower, upper, &fetched);
// Calculate the expected count, potentially factoring in nulls.
size_t expected_sel_count = ExpectedCount(nrows, cardinality, lower_not_null, upper);
@@ -156,7 +156,7 @@ public:
ASSERT_OK(tablet()->Flush());
}
- void TestTimedScanWithBounds(size_t nrows, size_t cardinality, size_t strlen, size_t lower_val,
+ void TestTimedScanWithBounds(size_t strlen, size_t lower_val,
size_t upper_val, int* fetched) {
Arena arena(128);
AutoReleasePool pool;
http://git-wip-us.apache.org/repos/asf/kudu/blob/741bdfa4/src/kudu/tserver/tablet_server-test-base.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_server-test-base.cc b/src/kudu/tserver/tablet_server-test-base.cc
index 6bc2f75..0ab114e 100644
--- a/src/kudu/tserver/tablet_server-test-base.cc
+++ b/src/kudu/tserver/tablet_server-test-base.cc
@@ -388,9 +388,10 @@ void TabletServerTestBase::VerifyRows(const Schema& schema,
ASSERT_OK(tablet_replica_->tablet()->NewRowIterator(schema, &iter));
ASSERT_OK(iter->Init(NULL));
- const size_t batch_size =
- std::max(size_t(1), std::min(expected.size() / 10,
- 4*1024*1024 / schema.byte_size()));
+ int batch_size = std::max<int>(1,
+ std::min<int>(expected.size() / 10,
+ 4*1024*1024 / schema.byte_size()));
+
Arena arena(32*1024);
RowBlock block(schema, batch_size, &arena);
http://git-wip-us.apache.org/repos/asf/kudu/blob/741bdfa4/src/kudu/tserver/tablet_service.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_service.cc b/src/kudu/tserver/tablet_service.cc
index e3af58b..e3838c4 100644
--- a/src/kudu/tserver/tablet_service.cc
+++ b/src/kudu/tserver/tablet_service.cc
@@ -1877,7 +1877,7 @@ Status TabletServiceImpl::HandleContinueScanRequest(const ScanRequestPB* req,
RowBlock block(scanner->iter()->schema(),
FLAGS_scanner_batch_size_rows, &arena);
- // TODO: in the future, use the client timeout to set a budget. For now,
+ // TODO(todd): in the future, use the client timeout to set a budget. For now,
// just use a half second, which should be plenty to amortize call overhead.
int budget_ms = 500;
MonoTime deadline = MonoTime::Now() + MonoDelta::FromMilliseconds(budget_ms);