You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/12 07:09:59 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
xiaoxiang781216 opened a new pull request, #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840
## Summary
to avoid the conflict with the 3rd party library
note: all major libc provider doesn't put crc8.h, crc16.h and crc32.h directly under include folder.
## Impact
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213031315
> Yes, I build with sim:spiffs
Do you get a local CI clean build with the apps PR and this one? I.E Do we have to ignore the CI fails or should the PR be a draft until it is ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213034459
> > Yes, I build with sim:spiffs
>
> Do you get a local CI clean build with the apps PR and this one? I.E Do we have to ignore the CI fails or should the PR be a draft until it is ready?
Yes, it's ready for merge: sim:spiffs cover the change in libc and apps/fstest. If there is any break, I will monitor the CI in the next couple hours to fix the potential break quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213015493
@xiaoxiang781216 - are you getting a clean build locally with apps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213114480
I will take a look EOD. Anyway CI is failing, so I still have some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213045823
@pkarashchenko - Did you want a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6840: libc: Move crc8.h, crc16.h and crc32.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6840:
URL: https://github.com/apache/incubator-nuttx/pull/6840#issuecomment-1213027614
Yes, I build with sim:spiffs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org