You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/08/07 20:52:23 UTC
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7609
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
This is cleanup that wasn't included in Part 2.
Testing:
Confirmed that everything (including be tests) built ok,
buffered-tuple-stream-v2-test passed and that I could
run a couple of basic queries.
Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
M be/src/exec/hash-table-test.cc
M be/src/exec/hash-table.cc
M be/src/exec/hash-table.h
M be/src/exec/hash-table.inline.h
M be/src/exec/partitioned-aggregation-node-ir.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-aggregation-node.h
M be/src/exec/partitioned-hash-join-builder-ir.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node-ir.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/partitioned-hash-join-node.inline.h
M be/src/runtime/CMakeLists.txt
R be/src/runtime/buffered-tuple-stream-test.cc
R be/src/runtime/buffered-tuple-stream.cc
R be/src/runtime/buffered-tuple-stream.h
R be/src/runtime/buffered-tuple-stream.inline.h
21 files changed, 194 insertions(+), 194 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/7609/1
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
This is cleanup that wasn't included in Part 2.
Testing:
Confirmed that everything (including be tests) built ok,
buffered-tuple-stream-v2-test passed and that I could
run a couple of basic queries.
Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Reviewed-on: http://gerrit.cloudera.org:8080/7609
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
M be/src/exec/hash-table-test.cc
M be/src/exec/hash-table.cc
M be/src/exec/hash-table.h
M be/src/exec/hash-table.inline.h
M be/src/exec/partitioned-aggregation-node-ir.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-aggregation-node.h
M be/src/exec/partitioned-hash-join-builder-ir.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node-ir.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/partitioned-hash-join-node.inline.h
M be/src/runtime/CMakeLists.txt
R be/src/runtime/buffered-tuple-stream-test.cc
R be/src/runtime/buffered-tuple-stream.cc
R be/src/runtime/buffered-tuple-stream.h
R be/src/runtime/buffered-tuple-stream.inline.h
21 files changed, 194 insertions(+), 194 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1012/
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1006/
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b23d7c2d7488d9f74b08cc9adb4ed1a93e3591
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No