You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/04/18 10:48:23 UTC
[GitHub] brooklyn-server pull request #640: Fix address publish bug
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-server/pull/640
Fix address publish bug
When a server provisions but JClouds fails to connect to it, the server is killed and re-provisioned. When this happens the private and public address of the old server remain in the `host.address` sensors because of a null check in `DefaultConnectivityResolver`. This PR removes that so the machine correctly obtains the address of the re-provisioned machine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-server fix-address-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #640
----
commit f3fa60050c83ee661d4f1d96dcf4298e481408d7
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-04-18T10:44:54Z
Fix address publish bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #640: Fix address publish bug
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #640: Fix address publish bug
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/640
+1 to the change. I was probably being overly cautious about not triggering duplicate sensor change events (since the block will run during rebind). I'm not aware of any downstream projects reliant on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #640: Fix address publish bug
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/640
Via separate comms, @sjcorbett said to @drigodwin that ... the null-check was added because he was worried about triggering an event upon rebind. But probably being too cautious and can probably remove it. Nothing in downstream projects is relying on it at the moment, as far as we know.
So I think this is good to merge.
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #640: Fix address publish bug
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/640
LGTM.
@sjcorbett any thoughts on the implications of removing this null check? It looks safe to me, but then would it interfere with any downstream projects?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---