You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Pavel Tupitsyn (JIRA)" <ji...@apache.org> on 2015/11/03 14:09:27 UTC

[jira] [Comment Edited] (IGNITE-1835) .Net: Use thread-local pool to store schemas in PortableWriter

    [ https://issues.apache.org/jira/browse/IGNITE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987203#comment-14987203 ] 

Pavel  Tupitsyn edited comment on IGNITE-1835 at 11/3/15 1:09 PM:
------------------------------------------------------------------

I'm not sure about shrinking. If the array has come to a certain size, it happened for a reason, and it will probably happen again. Doing 2 reallocations of an array on each write will perform poorly. And we are talking about small savings here. In Java there is a 256*4=1KB limit for the buffer.

IGNITE-1814 has been merged to 1282, and I've merged from 1282.


was (Author: ptupitsyn):
I'm not sure about shrinking. If the array has come to a certain size, it happened for a reason, and it will probably happen again. Doing 2 reallocations of an array on each write will perform poorly. 

And we are talking about laughable savings here. In Java there is a 256*4=1KB limit for the buffer.

> .Net: Use thread-local pool to store schemas in PortableWriter
> --------------------------------------------------------------
>
>                 Key: IGNITE-1835
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1835
>             Project: Ignite
>          Issue Type: Task
>          Components: interop
>    Affects Versions: 1.5
>            Reporter: Pavel  Tupitsyn
>            Assignee: Pavel  Tupitsyn
>             Fix For: 1.5
>
>
> Avoid array allocations in PortableWriter by keeping a single ThreadLocal array to store schema fields.
> See SchemaHolder in Java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)