You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/30 15:38:07 UTC
[GitHub] [shardingsphere] abhinav-koppula opened a new pull request, #21291: [Issue #20396]-Add unit test for DefaultSQLParserRuleConfigurationBuilder
abhinav-koppula opened a new pull request, #21291:
URL: https://github.com/apache/shardingsphere/pull/21291
Fixes #20396 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21291: [Issue #20396]-Add unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21291:
URL: https://github.com/apache/shardingsphere/pull/21291#issuecomment-1264307296
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21291](https://codecov.io/gh/apache/shardingsphere/pull/21291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c32b882) into [master](https://codecov.io/gh/apache/shardingsphere/commit/bc2d9b634288205b7602fbe00d66161c8a585ffe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc2d9b6) will **increase** coverage by `0.03%`.
> The diff coverage is `34.05%`.
```diff
@@ Coverage Diff @@
## master #21291 +/- ##
============================================
+ Coverage 61.62% 61.66% +0.03%
- Complexity 2555 2556 +1
============================================
Files 4112 4113 +1
Lines 56671 56686 +15
Branches 7533 7534 +1
============================================
+ Hits 34925 34956 +31
+ Misses 18800 18782 -18
- Partials 2946 2948 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mgr/InvalidMGRGroupNameConfigurationException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL2V4Y2VwdGlvbi9tZ3IvSW52YWxpZE1HUkdyb3VwTmFtZUNvbmZpZ3VyYXRpb25FeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...y/mysql/exception/mgr/InvalidMGRModeException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL2V4Y2VwdGlvbi9tZ3IvSW52YWxpZE1HUk1vZGVFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mysql/exception/mgr/InvalidMGRPluginException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL2V4Y2VwdGlvbi9tZ3IvSW52YWxpZE1HUlBsdWdpbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mgr/InvalidMGRReplicationGroupMemberException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL2V4Y2VwdGlvbi9tZ3IvSW52YWxpZE1HUlJlcGxpY2F0aW9uR3JvdXBNZW1iZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...xception/metadata/EncryptColumnAlterException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZXhjZXB0aW9uL21ldGFkYXRhL0VuY3J5cHRDb2x1bW5BbHRlckV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ption/metadata/EncryptColumnNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZXhjZXB0aW9uL21ldGFkYXRhL0VuY3J5cHRDb2x1bW5Ob3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...syntax/UnsupportedEncryptInsertValueException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZXhjZXB0aW9uL3N5bnRheC9VbnN1cHBvcnRlZEVuY3J5cHRJbnNlcnRWYWx1ZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ception/syntax/UnsupportedEncryptSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZXhjZXB0aW9uL3N5bnRheC9VbnN1cHBvcnRlZEVuY3J5cHRTUUxFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../algorithm/InvalidReadDatabaseWeightException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9leGNlcHRpb24vYWxnb3JpdGhtL0ludmFsaWRSZWFkRGF0YWJhc2VXZWlnaHRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../syntax/UnsupportedShadowInsertValueException.java](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvZXhjZXB0aW9uL3N5bnRheC9VbnN1cHBvcnRlZFNoYWRvd0luc2VydFZhbHVlRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [151 more](https://codecov.io/gh/apache/shardingsphere/pull/21291/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] abhinav-koppula commented on a diff in pull request #21291: [Issue #20396]-Add unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
abhinav-koppula commented on code in PR #21291:
URL: https://github.com/apache/shardingsphere/pull/21291#discussion_r985072550
##########
shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-core/src/test/java/org/apache/shardingsphere/parser/rule/builder/DefaultSQLParserRuleConfigurationBuilderTest.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.parser.rule.builder;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertFalse;
+import static org.hamcrest.Matchers.is;
+
+import org.apache.shardingsphere.parser.config.SQLParserRuleConfiguration;
+import org.apache.shardingsphere.parser.constant.SQLParserOrder;
+import org.junit.Test;
+
+public final class DefaultSQLParserRuleConfigurationBuilderTest {
+
+ @Test
+ public void assertBuild() {
+ SQLParserRuleConfiguration actualResult = new DefaultSQLParserRuleConfigurationBuilder().build();
Review Comment:
done, https://github.com/apache/shardingsphere/pull/21291/commits/c32b8827ed1f09965d04a8f07f3003e89c9ddb2d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #21291: [Issue #20396]-Add unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #21291:
URL: https://github.com/apache/shardingsphere/pull/21291#discussion_r985065614
##########
shardingsphere-kernel/shardingsphere-parser/shardingsphere-parser-core/src/test/java/org/apache/shardingsphere/parser/rule/builder/DefaultSQLParserRuleConfigurationBuilderTest.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.parser.rule.builder;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertFalse;
+import static org.hamcrest.Matchers.is;
+
+import org.apache.shardingsphere.parser.config.SQLParserRuleConfiguration;
+import org.apache.shardingsphere.parser.constant.SQLParserOrder;
+import org.junit.Test;
+
+public final class DefaultSQLParserRuleConfigurationBuilderTest {
+
+ @Test
+ public void assertBuild() {
+ SQLParserRuleConfiguration actualResult = new DefaultSQLParserRuleConfigurationBuilder().build();
Review Comment:
Can you rename actualResult to actual?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #21291: [Issue #20396]-Add unit test for DefaultSQLParserRuleConfigurationBuilder
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #21291:
URL: https://github.com/apache/shardingsphere/pull/21291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org