You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/09/08 10:54:10 UTC
Review Request 51721: Invert authorization logic in
RangerKafkaAuthorizer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51721/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1171
https://issues.apache.org/jira/browse/RANGER-1171
Repository: ranger
Description
-------
Similar to RANGER-1095, the RangerKafkaAuthorizer has a boolean "returnValue" which defaults to true. However, there is a catch clause which just logs an error, meaning that a RuntimeException could result in successful authorization. Instead, the boolean should default to false.
Diffs
-----
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 8ce8233
Diff: https://reviews.apache.org/r/51721/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 51721: Invert authorization logic in
RangerKafkaAuthorizer
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51721/#review148223
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 8, 2016, 10:54 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51721/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 10:54 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1171
> https://issues.apache.org/jira/browse/RANGER-1171
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Similar to RANGER-1095, the RangerKafkaAuthorizer has a boolean "returnValue" which defaults to true. However, there is a catch clause which just logs an error, meaning that a RuntimeException could result in successful authorization. Instead, the boolean should default to false.
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 8ce8233
>
> Diff: https://reviews.apache.org/r/51721/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>