You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2014/09/06 00:48:28 UTC

[jira] [Commented] (MAPREDUCE-6075) HistoryServerFileSystemStateStore can create zero-length files

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123734#comment-14123734 ] 

Tsuyoshi OZAWA commented on MAPREDUCE-6075:
-------------------------------------------

[~jlowe], thanks for your contribution. IIUC, we shouldn't retry close after exception. Please check the following page for more detail: 
http://linux.die.net/man/2/close 

How about calling flush() instead of close() in try blocks?

> HistoryServerFileSystemStateStore can create zero-length files
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-6075
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6075
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 2.3.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-6075.patch
>
>
> When the history server state store writes a token file it uses IOUtils.cleanup() to close the file which will silently ignore errors.  This can lead to empty token files in the state store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)