You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 11:46:50 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #14510: [Transaction] Fix topicTransactionBuffer handle null snapshot (#12758)
eolivelli opened a new pull request #14510:
URL: https://github.com/apache/pulsar/pull/14510
fix https://github.com/apache/pulsar/issues/12754
Now when delete topic, we will write a null value to Transaction buffer snapshot topic, other topic recover by this transaction buffer snapshot system topic, will produce NPE
judge NPE logic
(cherry picked from commit c90c89b07ce544b92becedfaa7a0090b4b73edd2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14510: [Transaction] Fix topicTransactionBuffer handle null snapshot (#12758)
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14510:
URL: https://github.com/apache/pulsar/pull/14510#discussion_r816715098
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -472,12 +472,15 @@ public void run() {
try {
while (reader.hasMoreEvents()) {
Message<TransactionBufferSnapshot> message = reader.readNext();
- TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
- if (topic.getName().equals(transactionBufferSnapshot.getTopicName())) {
- callBack.handleSnapshot(transactionBufferSnapshot);
- this.startReadCursorPosition = PositionImpl.get(
- transactionBufferSnapshot.getMaxReadPositionLedgerId(),
- transactionBufferSnapshot.getMaxReadPositionEntryId());
+ if (topic.getName().equals(message.getKey())) {
+ TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
+ if (transactionBufferSnapshot != null) {
+ hasSnapshot = true;
Review comment:
this should be removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #14510: [Transaction] Fix topicTransactionBuffer handle null snapshot (#12758)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #14510:
URL: https://github.com/apache/pulsar/pull/14510#discussion_r816738573
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -472,12 +472,15 @@ public void run() {
try {
while (reader.hasMoreEvents()) {
Message<TransactionBufferSnapshot> message = reader.readNext();
- TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
- if (topic.getName().equals(transactionBufferSnapshot.getTopicName())) {
- callBack.handleSnapshot(transactionBufferSnapshot);
- this.startReadCursorPosition = PositionImpl.get(
- transactionBufferSnapshot.getMaxReadPositionLedgerId(),
- transactionBufferSnapshot.getMaxReadPositionEntryId());
+ if (topic.getName().equals(message.getKey())) {
+ TransactionBufferSnapshot transactionBufferSnapshot = message.getValue();
+ if (transactionBufferSnapshot != null) {
+ hasSnapshot = true;
Review comment:
good catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14510: [Transaction] Fix topicTransactionBuffer handle null snapshot (#12758)
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14510:
URL: https://github.com/apache/pulsar/pull/14510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org