You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Ryan Williams (JIRA)" <ad...@incubator.apache.org> on 2006/05/13 00:27:09 UTC
[jira] Created: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
--------------------------------------------------------------------
Key: ADFFACES-9
URL: http://issues.apache.org/jira/browse/ADFFACES-9
Project: MyFaces ADF-Faces
Type: Bug
Components: Build
Reporter: Ryan Williams
Priority: Minor
Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Adam Winer closed ADFFACES-9:
-----------------------------
Resolution: Fixed
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Assignee: Adam Winer
> Priority: Minor
> Attachments: test_patch.txt
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Ryan Williams (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Ryan Williams updated ADFFACES-9:
---------------------------------
Status: Patch Available (was: Open)
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Priority: Minor
> Attachments: test_patch.txt
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Ryan Williams (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Ryan Williams updated ADFFACES-9:
---------------------------------
Attachment: test_patch.txt
Here's a patch that addresses the brittleness by making the comparison not one for equality, but for a range of values, which should cover most incidental serialization variance.
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Priority: Minor
> Attachments: test_patch.txt
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-9:
--------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: https://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.0.0-incubating-core
> Reporter: Ryan Williams
> Assigned To: Adam Winer
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: test_patch.txt
>
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Adam Winer reassigned ADFFACES-9:
---------------------------------
Assign To: Adam Winer
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Assignee: Adam Winer
> Priority: Minor
> Attachments: test_patch.txt
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Ryan Williams (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Ryan Williams updated ADFFACES-9:
---------------------------------
Status: Patch Available (was: Open)
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Priority: Minor
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-9) Brittleness in RowKeySetImplTest.java
and RowKeySetTreeImplTest.java
Posted by "Ryan Williams (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
Ryan Williams updated ADFFACES-9:
---------------------------------
Status: Open (was: Patch Available)
> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
> Key: ADFFACES-9
> URL: http://issues.apache.org/jira/browse/ADFFACES-9
> Project: MyFaces ADF-Faces
> Type: Bug
> Components: Build
> Reporter: Ryan Williams
> Priority: Minor
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle. They check the the length in bytes of a serialized object against a hard-coded value. I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename. We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon. The tests should be changed so that they don't compare for equality with a particular value.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira