You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2023/08/15 13:34:49 UTC

[Impala-ASF-CR] CDPD-50675: Include crypto functions supported by Hive

pranav.lodha@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20364


Change subject: CDPD-50675: Include crypto functions supported by Hive
......................................................................

CDPD-50675: Include crypto functions supported by Hive

aes_encrypt / aes_decrypt functions currently support 256-bit key length
 encryption. It uses EncrytionKey class implemented in Impala for
 encryption/decryption. We set our Cipher mode to AES_256_CTR in
 EncrytionKey. CTR mode requires us to initialize iv_ vector of size
 AES_BLOCK_SIZE which will act as the first input buffer for
 encryption and the last input buffer for decryption. After initializing
 all EncrytionKey class data fields we finally encrypt our buffer data
 in input_vec and store the result in the same input_vec.
At last, we return the StringVal of our input_vec buffer.

Some key length checks are also there which makes sure we are
 only using 256-bit key length for both aes_encrypt and aes_decrypt.

Change-Id: I78389ff527ddb2c3fc01d4c6c56eca1c07753e5d
---
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
M bin/cmake_aux/create_py3_virtualenv.sh
M common/function-registry/impala_functions.py
6 files changed, 82 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/20364/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78389ff527ddb2c3fc01d4c6c56eca1c07753e5d
Gerrit-Change-Number: 20364
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] CDPD-50675: Include crypto functions supported by Hive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20364 )

Change subject: CDPD-50675: Include crypto functions supported by Hive
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20364/1/be/src/exprs/string-functions.h
File be/src/exprs/string-functions.h:

http://gerrit.cloudera.org:8080/#/c/20364/1/be/src/exprs/string-functions.h@105
PS1, Line 105:   static StringVal aes_encrypt(FunctionContext*, const StringVal& input, const StringVal& key);
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/20364/1/be/src/exprs/string-functions.h@106
PS1, Line 106:   static StringVal aes_decrypt(FunctionContext*, const StringVal& input, const StringVal& key);
line too long (95 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/20364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78389ff527ddb2c3fc01d4c6c56eca1c07753e5d
Gerrit-Change-Number: 20364
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 13:35:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] CDPD-50675: Include crypto functions supported by Hive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20364 )

Change subject: CDPD-50675: Include crypto functions supported by Hive
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13753/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78389ff527ddb2c3fc01d4c6c56eca1c07753e5d
Gerrit-Change-Number: 20364
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Aug 2023 13:59:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] CDPD-50675: Include crypto functions supported by Hive

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
pranav.lodha@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/20364 )

Change subject: CDPD-50675: Include crypto functions supported by Hive
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/20364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I78389ff527ddb2c3fc01d4c6c56eca1c07753e5d
Gerrit-Change-Number: 20364
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>