You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/10 09:54:09 UTC
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #73: feat: support for controller-only deployment
tao12345666333 opened a new pull request #73:
URL: https://github.com/apache/apisix-helm-chart/pull/73
Add new top-level `apisix.enabled` setting to control whether
deploy apisix-ingress controller only.
Signed-off-by: Jintao Zhang <zh...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #73: feat: support for controller-only deployment
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #73:
URL: https://github.com/apache/apisix-helm-chart/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #73: feat: support for controller-only deployment
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #73:
URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629228964
##########
File path: charts/apisix/values.yaml
##########
@@ -14,6 +14,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+apisix:
+ # Enable or disable Apache APISIX itself
+ # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller
+ enabled: true
Review comment:
Yep. I did not modify it because I was worried about breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #73: feat: support for controller-only deployment
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #73:
URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629246563
##########
File path: charts/apisix/values.yaml
##########
@@ -14,6 +14,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+apisix:
+ # Enable or disable Apache APISIX itself
+ # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller
+ enabled: true
Review comment:
There is no place to reference this value yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #73: feat: support for controller-only deployment
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #73:
URL: https://github.com/apache/apisix-helm-chart/pull/73#discussion_r629227642
##########
File path: charts/apisix/values.yaml
##########
@@ -14,6 +14,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+apisix:
+ # Enable or disable Apache APISIX itself
+ # Set it to flase and ingress-controller.enabled=true will deploy only ingress-controller
+ enabled: true
Review comment:
There are so many top-level fields which are related with APISIX, I think we can put all of them under the apisix field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org