[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2322: feat: Add more fields to limit-count plugin

[GitBox <gi...@apache.org>]

Baoyuantop commented on a change in pull request #2322:
URL: https://github.com/apache/apisix-dashboard/pull/2322#discussion_r810728586



##########
File path: web/src/components/Plugin/UI/limit-count.tsx
##########
@@ -323,6 +323,35 @@ const LimitCount: React.FC<Props> = ({ form, schema }) => {
           ))}
         </Select>
       </Form.Item>
+      <Form.Item
+        label="group"
+        name="group"
+        tooltip={formatMessage({ id: 'component.pluginForm.limit-count.key.tooltip' })}
+      >
+        <Input />
+      </Form.Item>
+      <Form.Item
+        initialValue={properties.allow_degradation.default}
+        label="allow_degradation"
+        name="allow_degradation"
+        tooltip={formatMessage({
+          id: 'component.pluginForm.limit-count.allow_degradation.tooltip',
+        })}
+        valuePropName="checked"
+      >
+        <Switch defaultChecked={properties.allow_degradation.default} />
+      </Form.Item>

Review comment:
       why `initialValue` and `defaultChecked` both exist?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org