You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/09/28 00:20:16 UTC
Review Request 62641: Removed multiple reasons from
ContainerTermination.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62641/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-7963
https://issues.apache.org/jira/browse/MESOS-7963
Repository: mesos
Description
-------
Since the ContainerLimitation is no longer ever populated with more than
one TaskStatus.Reason, make it optional rather than repeated.
Diffs
-----
include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
src/slave/slave.cpp 75e2e25c438637e2b1731f9fd01b6fe297687c50
src/tests/containerizer/io_switchboard_tests.cpp bf7917ac72edff22561545a807bd17b610aec796
Diff: https://reviews.apache.org/r/62641/diff/1/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 62641: Removed multiple reasons from
ContainerTermination.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62641/#review187526
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 28, 2017, 8:20 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62641/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 8:20 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the ContainerLimitation is no longer ever populated with more than
> one TaskStatus.Reason, make it optional rather than repeated.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
> src/tests/containerizer/io_switchboard_tests.cpp bf7917ac72edff22561545a807bd17b610aec796
>
>
> Diff: https://reviews.apache.org/r/62641/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 62641: Removed multiple reasons from
ContainerTermination.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62641/#review186956
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 28, 2017, 12:20 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62641/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 12:20 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-7963
> https://issues.apache.org/jira/browse/MESOS-7963
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the ContainerLimitation is no longer ever populated with more than
> one TaskStatus.Reason, make it optional rather than repeated.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685
> src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345
> src/slave/slave.cpp 75e2e25c438637e2b1731f9fd01b6fe297687c50
> src/tests/containerizer/io_switchboard_tests.cpp bf7917ac72edff22561545a807bd17b610aec796
>
>
> Diff: https://reviews.apache.org/r/62641/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>