[jira] [Commented] (TINKERPOP3-690) Be able to OPT_OUT for Standard, but not Computer

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727966#comment-14727966 ] 

stephen mallette commented on TINKERPOP3-690:
---------------------------------------------

I'm going to make the "breaking" comment here a little more clear.  This change should only be a problem for those who run {{GraphComputer}} tests (e.g. {{ProcessComputerSuite}}).  If you do run these tests, then you need to edit your {{GraphProvider}} implementation for those suites to include the aforementioned {{GraphProvider.Descriptor}} annotation.

Here's an example with from the {{HadoopGiraphGraphProvider}}:

https://github.com/apache/incubator-tinkerpop/blob/04ba481facf9234669092467b73c05eb9b4c0301/hadoop-gremlin/src/test/java/org/apache/tinkerpop/gremlin/hadoop/process/computer/giraph/HadoopGiraphGraphProvider.java#L30

> Be able to OPT_OUT for Standard, but not Computer
> -------------------------------------------------
>
>                 Key: TINKERPOP3-690
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-690
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.0.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: stephen mallette
>              Labels: breaking
>             Fix For: 3.0.1-incubating, 3.1.0-incubating
>
>
> {{HadoopGraph}} currently have this:
> {code}
> @Graph.OptOut(
>         test = "org.apache.tinkerpop.gremlin.process.traversal.step.map.CountTest$Traversals",
>         method = "g_V_repeatXoutX_timesX8X_count",
>         reason = "Hadoop-Gremlin is OLAP-oriented and for OLTP operations, linear-scan joins are required. This particular tests takes many minutes to execute.")
> {code}
> However, I only want to OPT_OUT for Standard, not for Computer. It would be good to be able to make OPT_OUT for particular engines.
> Next, and more to the point, see this:
> {code}
> @Graph.OptOut(
>         test = "org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest",
>         method = "shouldHaveConsistentMemoryVertexPropertiesAndExceptions",
>         reason = "Giraph does a hard kill on failure and stops threads which stops test cases. Exception handling semantics are correct though.")
> {code}
> {{SparkGraphComputer}} does this fine, its only {{GiraphGraphComputer}} that fails the entire JVM. Again, be nice to say OPT_OUT for Giraph, but not for Spark.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)