You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Swapan Shridhar (JIRA)" <ji...@apache.org> on 2016/10/11 23:08:20 UTC
[jira] [Commented] (AMBARI-18575) Fix for improving time taken by
'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
[ https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566908#comment-15566908 ]
Swapan Shridhar commented on AMBARI-18575:
------------------------------------------
Individual tests time taken is as follows:
*UpgradeCatalog221Test:*
- init() function takes most of the time.
||Test No.||Test||Time (micro secs)||
| |init()|10197|
|1|testUpdateAmsHbaseSiteConfigs| 198|
| |init()|3140|
|2|testExecuteDDLUpdates| 17|
| |init()|2377|
|3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
| |init()|2396|
|4|testExecuteDMLUpdates| 18|
| |init()|2203|
|5|testUpdateTezConfigs| 11|
| |init()|2011|
|6|testUpdateAmsHbaseEnvContent| 0|
| |init()|1953|
|7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
| |init()|1882|
|8|testUpdateOozieConfigs| 2|
| |init()|1871|
|9|testUpdateAmsEnvContent| 0|
| |init()|1801|
|10|testUpdateRangerKmsDbksConfigs| 2|
| |init()|1735|
|11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
| |init()|1693|
|12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
| |init()|1626|
|13|testUpdateAlertDefinitions| 19|
*ExecutionScheduleManagerTest:*
- setup() function takes most of the time.
||Test No.||Test||Time (micro secs)||
| |setup()|10111|
|1|testUpdateBatchRequest| 249|
| |after()|2|
| |setup()|3234|
|2|testExecuteBatchRequest| 59|
| |after()|1|
| |setup()|2480|
|3|testScheduleBatch| 40|
| |after()|1|
| |setup()|2381|
|4|testFinalizeBeforeExit| 28|
| |after()|1|
| |setup()|2312|
|5|testDeleteAllJobs| 17|
| |after()|1|
| |setup()|2141|
|6|testFinalizeBatch| 64|
| |after()|1|
| |setup()|1970|
|7|testPointInTimeExecutionJob| 18|
| |after()|2|
| |setup()|1944|
|8|testHasToleranceThresholdExceeded| 68|
| |after()|1|
| |setup()|1994|
|9|testGetBatchRequestResponse| 59|
| |after()|1|
- Thus, majority time is taken by the setup methods, and they are @Before methods.
*Fix:* Make then @BeforeClass methods.
> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
> ------------------------------------------------------------------------------------------------------
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.4.2
> Reporter: Swapan Shridhar
> Assignee: Swapan Shridhar
> Fix For: 2.5.0
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in BUG : BUG-65777
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)