[GitHub] [pulsar] nodece commented on a diff in pull request #18121: [feat][client] Add ClientConfiguration options for in memory TLS certs

[GitBox <gi...@apache.org>]

nodece commented on code in PR #18121:
URL: https://github.com/apache/pulsar/pull/18121#discussion_r1004637290


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java:
##########
@@ -162,6 +165,24 @@ public class ClientConfigurationData implements Serializable, Cloneable {
     )
     private String tlsTrustCertsFilePath = null;
 
+    @ApiModelProperty(
+            name = "tlsPrivateKey",
+            value = "The private key for the client certificate. Only used when tlsTrustStoreStream is non-null."
+    )
+    private PrivateKey tlsPrivateKey = null;

Review Comment:
   I agreed with Enrico, creating a provider is a good idea, because we have too many TLS configs on the builder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org