[jira] [Comment Edited] (KUDU-2109) TabletCopyClientSessionITest.TestCopyFromCrashedSource is flaky

["Alexey Serbin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KUDU-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224113#comment-17224113 ] 

Alexey Serbin edited comment on KUDU-2109 at 10/31/20, 4:35 PM:
----------------------------------------------------------------

The same error happened in DeleteTableITest.TestAtomicDeleteTablet (TSAN build).  I guess the underlying root cause is the same.  Attaching the log from the test run.


was (Author: aserbin):
The same error happened in (TSAN build).  I guess the underlying root cause is the same.  Attaching the log from the test run.

> TabletCopyClientSessionITest.TestCopyFromCrashedSource is flaky
> ---------------------------------------------------------------
>
>                 Key: KUDU-2109
>                 URL: https://issues.apache.org/jira/browse/KUDU-2109
>             Project: Kudu
>          Issue Type: Bug
>          Components: test, tserver
>    Affects Versions: 1.4.0
>            Reporter: Adar Dembo
>            Priority: Major
>             Fix For: NA
>
>         Attachments: 0_tablet_copy_client_session-itest.txt, delete_table-itest.2.txt.xz
>
>
> I've attached the full log from my test failure.
> I think I've found the issue too: the test assumes that if it finds an on-disk superblock in the TOMBSTONED state, the failed tablet copy has finished and it's safe to start another one. However, in TSTabletManager::RunTabletCopy, 'tc_client' goes out of scope before 'deleter', which means that the TabletCopyClient destructor (which deletes the on-disk data, flushing the superblock in the TOMBSTONED state) will run before the TransitionInProgress destructor (which removes the tablet's ID from the global map tracking transitions, allowing a new tablet copy to proceed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)