Re: [PR] Remove deprecated hasDataAccess method. [pinot]

["jadami10 (via GitHub)" <gi...@apache.org>]

jadami10 commented on code in PR #13574:
URL: https://github.com/apache/pinot/pull/13574#discussion_r1826889211


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControl.java:
##########
@@ -55,10 +40,8 @@ default boolean hasDataAccess(HttpHeaders httpHeaders, String tableName) {
    * @param endpointUrl the request url for which this access control is called
    * @return whether the client has permission
    */
-  default boolean hasAccess(@Nullable String tableName, AccessType accessType, HttpHeaders httpHeaders,
-      @Nullable String endpointUrl) {
-    return true;
-  }
+  boolean hasAccess(@Nullable String tableName, AccessType accessType, HttpHeaders httpHeaders,

Review Comment:
   Why does this no longer default `true`? This is backwards incompatible for users of this interface



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org