[GitHub] [iotdb] bigreybear commented on a diff in pull request #5976: [IOTDB-3216]Refactor Segments in SchemaFile to B+ Tree structure from list structure

[GitBox <gi...@apache.org>]

bigreybear commented on code in PR #5976:
URL: https://github.com/apache/iotdb/pull/5976#discussion_r883176206


##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/store/disk/schemafile/ISchemaPage.java:
##########
@@ -122,4 +119,21 @@ long transplantSegment(ISchemaPage srcPage, short segId, short newSegSize)
   long getPrevSegAddress(short segId) throws SegmentNotFoundException;
 
   String inspect() throws SegmentNotFoundException;
+
+  // TODO: methods below should belong to ISegment interface after abstraction refactor
+  //  along with methods that insert/remove/get records, seg/get segment address
+
+  String splitLeafSegment(String key, ByteBuffer recBuf, ISchemaPage dstPage, boolean inclineSplit)
+      throws MetadataException;
+
+  String splitInternalSegment(String key, int ptr, ISchemaPage dstPage, boolean inclineSplit)
+      throws MetadataException;

Review Comment:
   Now there are 2 classes extend an abstract class named `SchemaPage`, which are SegmentedPage and InternalPage respectively.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org