You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/15 03:35:53 UTC
[PR] [Test] Fix pipe memory ownership test compilation [iotdb]
Caideyipi opened a new pull request, #18881:
URL: https://github.com/apache/iotdb/pull/18881
## Description
`PipeMemoryManagerResizeTest.testPipeOwnershipAndInheritance` still calls the six-argument `PipeHeartbeatEvent` constructor removed by #18563, which breaks DataNode test compilation on master.
Supply `completionBarrier=false` and unbound epoch, generation, and source ID values so the test continues to use an ordinary heartbeat for memory ownership tracking.
## Validation
- Spotless passed for the changed test.
- Passed `mvn test -pl iotdb-core/datanode -am -Dtest=PipeMemoryManagerResizeTest#testPipeOwnershipAndInheritance -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false`.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] modified an existing unit test.
##### Key changed/added classes
`PipeMemoryManagerResizeTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] Fix pipe memory ownership test compilation [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18881:
URL: https://github.com/apache/iotdb/pull/18881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org