Bug in cmdline/main.c::parse_date(), with fix

[Lele Gaifax <le...@seldati.it>]

The function bombs when given any word not recognized by
revision_from_word(). When the argument to '-D' does not contain a ':'
char, the function sets `right_date' to NULL, then checks if the
parameter is a know "keyword", then it does a "if (*right_date)" that
is evidently wrong, and the intention was surely to do a "if
(right_date)", without deferring it.

I'm just starting looking around with svn, and I'm not yet up to
providing a proper patch, since I'm still learning the svn
way-of-doing. My apologies if this is not the right forum.

bye, lele.
-- 
nickname: Lele Gaifax	| Quando vivro' di quello che ho pensato ieri
real: Emanuele Gaifas	| comincero' ad aver paura di chi mi copia.
email: lele@seldati.it	|		-- Fortunato Depero, 1929.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug in cmdline/main.c::parse_date(), with fix

[Karl Fogel <kf...@newton.ch.collab.net>]

Lele Gaifax <le...@seldati.it> writes:
> The function bombs when given any word not recognized by
> revision_from_word(). When the argument to '-D' does not contain a ':'
> char, the function sets `right_date' to NULL, then checks if the
> parameter is a know "keyword", then it does a "if (*right_date)" that
> is evidently wrong, and the intention was surely to do a "if
> (right_date)", without deferring it.
> 
> I'm just starting looking around with svn, and I'm not yet up to
> providing a proper patch, since I'm still learning the svn
> way-of-doing. My apologies if this is not the right forum.

Lele,

I'm pretty sure the bug you describe is still present, but could you
take a look and see?  If it's still present, could you write a
reproduction case so we can easily demonstrate the bug to ourselves?
A patch is also welcome, of course, but the clear repro case is the
best thing.

We could maybe deduce a reproduction from your paragraph above, but it
would be *much* easier with transcript-style recipe.

Thanks,
-Karl


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug in cmdline/main.c::parse_date(), with fix

[Karl Fogel <kf...@newton.ch.collab.net>]

Lele Gaifax <le...@seldati.it> writes:
> The function bombs when given any word not recognized by
> revision_from_word(). When the argument to '-D' does not contain a ':'
> char, the function sets `right_date' to NULL, then checks if the
> parameter is a know "keyword", then it does a "if (*right_date)" that
> is evidently wrong, and the intention was surely to do a "if
> (right_date)", without deferring it.
> 
> I'm just starting looking around with svn, and I'm not yet up to
> providing a proper patch, since I'm still learning the svn
> way-of-doing. My apologies if this is not the right forum.

Thanks for the bug report!  That code hasn't been tested much yet, and
surely needs exercising and examination.

If you spotted a bug, yet don't feel comfortable posting a patch
because you're afraid it won't be in proper SVN style or something,
then we've been doing something wrong here.  You should feel
comfortable submitting the patch, and if any corrections are
necessary, the reviewer(s) will, we hope, point them out in as
constructive and friendly a manner as possible.

The best way to learn "the svn way-of-doing" is to get your patches
reviewed, early and often.  So please post! :-)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org