You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/23 02:20:13 UTC
[kudu-CR] [backup] Fix fromMs override option
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13080
Change subject: [backup] Fix fromMs override option
......................................................................
[backup] Fix fromMs override option
Fix the logic for deciding when to lookup old backups.
Previously the fromMs argument wasn’t being handled
correctly.
Additionally contains a small change to avoid converting
back and forth from Path to HPath multiple times.
Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 55 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13080/1
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Fix fromMs override option
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13080
to look at the new patch set (#2).
Change subject: [backup] Fix fromMs override option
......................................................................
[backup] Fix fromMs override option
Fix the logic for deciding when to lookup old backups.
Previously the fromMs argument wasn’t being handled
correctly.
Additionally contains a small change to avoid converting
back and forth from Path to HPath multiple times.
Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 58 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13080/2
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Fix fromMs override option
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13080 )
Change subject: [backup] Fix fromMs override option
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 14:43:05 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Fix fromMs override option
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13080 )
Change subject: [backup] Fix fromMs override option
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@71
PS1, Line 71: prev
> Nit: maybe "previous" here, to indicate that we couldn't find an incrementa
Done
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala@51
PS1, Line 51: def isIncremental: Boolean = {
> Would this be more useful if it returned a tri-state enum? Something like F
Perhaps this could be considered, but I would like to leave it out of this patch. It's not a trivial change since I use this to decide if we include the RowAction column or not. The "tri-state" is handled before this is ever called. I agree it could be cleaned up a bit.
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 13:28:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Fix fromMs override option
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13080 )
Change subject: [backup] Fix fromMs override option
......................................................................
[backup] Fix fromMs override option
Fix the logic for deciding when to lookup old backups.
Previously the fromMs argument wasn’t being handled
correctly.
Additionally contains a small change to avoid converting
back and forth from Path to HPath multiple times.
Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Reviewed-on: http://gerrit.cloudera.org:8080/13080
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 58 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Fix fromMs override option
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13080 )
Change subject: [backup] Fix fromMs override option
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala@71
PS1, Line 71: full
Nit: maybe "previous" here, to indicate that we couldn't find an incremental backup either? I get that we do really need to find a full at the beginning of the chain, but "previous" is similar to what we logged on L64.
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala@51
PS1, Line 51: def isIncremental: Boolean = {
Would this be more useful if it returned a tri-state enum? Something like FULL, INCREMENTAL, or AUTO_DETECT. Then KuduBackup could call it and switch on the result to decide what to do.
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@103
PS1, Line 103: logs.attach()
Nit: mind attaching only for the doBackup call? Makes it a bit easier to figure out what actually needs to be captured.
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 04:09:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Fix fromMs override option
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13080 )
Change subject: [backup] Fix fromMs override option
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13080/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@103
PS1, Line 103: logs.attach()
> Nit: mind attaching only for the doBackup call? Makes it a bit easier to fi
Done
--
To view, visit http://gerrit.cloudera.org:8080/13080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3abc47dd9d1441ba269dfc9405691f79e6615d
Gerrit-Change-Number: 13080
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 13:28:41 +0000
Gerrit-HasComments: Yes