You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Akanksha Agrawal <ak...@gmail.com> on 2015/03/19 05:14:58 UTC

Review Request 32233: Replaced raw pointer by Owned pointer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

Replaced raw pointer by Owned pointer


Diffs
-----

  src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
  src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 

Diff: https://reviews.apache.org/r/32233/diff/


Testing
-------


Thanks,

Akanksha Agrawal


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Akanksha Agrawal <ak...@gmail.com>.

> On March 20, 2015, 11:01 a.m., Bernd Mathiske wrote:
> > LGTM. Thanks!

Thank you! Could you please merge this?


- Akanksha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77197
-----------------------------------------------------------


On March 20, 2015, 8:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Akanksha Agrawal <ak...@gmail.com>.

> On March 20, 2015, 11:01 a.m., Bernd Mathiske wrote:
> > LGTM. Thanks!
> 
> Akanksha Agrawal wrote:
>     Thank you! Could you please merge this?
> 
> Bernd Mathiske wrote:
>     I'd love to, but I am not a committer. I see you have dedicated this review to Ben Mahler. He is a committer. I just wanted to help reviewing :-)

Okay. Thanks for reviewing.:)


- Akanksha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77197
-----------------------------------------------------------


On March 20, 2015, 8:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Bernd Mathiske <be...@mesosphere.io>.

> On March 20, 2015, 4:01 a.m., Bernd Mathiske wrote:
> > LGTM. Thanks!
> 
> Akanksha Agrawal wrote:
>     Thank you! Could you please merge this?

I'd love to, but I am not a committer. I see you have dedicated this review to Ben Mahler. He is a committer. I just wanted to help reviewing :-)


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77197
-----------------------------------------------------------


On March 20, 2015, 1:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 1:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77197
-----------------------------------------------------------


LGTM. Thanks!

- Bernd Mathiske


On March 20, 2015, 1:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 1:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77192
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32233]

All tests passed.

- Mesos ReviewBot


On March 20, 2015, 8:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77259
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 20, 2015, 8:11 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8:11 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Akanksha Agrawal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/
-----------------------------------------------------------

(Updated March 20, 2015, 8:11 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Aligned the parameters


Repository: mesos


Description
-------

Replaced raw pointer by Owned pointer


Diffs (updated)
-----

  src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
  src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 

Diff: https://reviews.apache.org/r/32233/diff/


Testing
-------


Thanks,

Akanksha Agrawal


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77179
-----------------------------------------------------------



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment125059>

    Can you please try again? Did you perhaps try this with an editor that uses TAB? You can use blanks to get the alignment you want, since we should replace TABs with blanks anyway. I downloaded your patch, appplied it and tried. It worked.


- Bernd Mathiske


On March 19, 2015, 6:47 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 6:47 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Akanksha Agrawal <ak...@gmail.com>.

> On March 19, 2015, 3:11 p.m., Bernd Mathiske wrote:
> > src/slave/containerizer/external_containerizer.cpp, line 239
> > <https://reviews.apache.org/r/32233/diff/2/?file=899898#file899898line239>
> >
> >     dispatch(process.get(),
> >              &ExternalContainerizerProcess::destroy,
> >              containerId);

The three parameters could not be aligned one below other properly. That is why I kept process.get() on another line.
And yes I did make check.


- Akanksha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77047
-----------------------------------------------------------


On March 19, 2015, 1:47 p.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 1:47 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77047
-----------------------------------------------------------



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124839>

    dispatch(process.get(),
             &ExternalContainerizerProcess::destroy,
             containerId);


Testing done?

- Bernd Mathiske


On March 19, 2015, 6:47 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 6:47 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77046
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32233]

All tests passed.

- Mesos ReviewBot


On March 19, 2015, 1:47 p.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 1:47 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Akanksha Agrawal <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/
-----------------------------------------------------------

(Updated March 19, 2015, 1:47 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Did formatting of function arguments.


Repository: mesos


Description
-------

Replaced raw pointer by Owned pointer


Diffs (updated)
-----

  src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
  src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 

Diff: https://reviews.apache.org/r/32233/diff/


Testing
-------


Thanks,

Akanksha Agrawal


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77012
-----------------------------------------------------------



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124770>

    Put each parameter on a new line if they don't all fit in one:
    
        return dispatch(process.get(),
                        &ExternalContainerizerProcess::recover,
                        state);



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124769>

    Align the parameters like this:
    
        return dispatch(process.get(),                        
                        &ExternalContainerizerProcess::launch,
                        containerId,
                        None(),
                        executorInfo,
                        directory,



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124771>

    Align parameters.



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124773>

    Align parameters.



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124774>

    1 param per line



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124775>

    1 param per line



src/slave/containerizer/external_containerizer.cpp
<https://reviews.apache.org/r/32233/#comment124776>

    1 param per line


- Bernd Mathiske


On March 18, 2015, 9:14 p.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 9:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>


Re: Review Request 32233: Replaced raw pointer by Owned pointer

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77010
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32233]

All tests passed.

- Mesos ReviewBot


On March 19, 2015, 4:14 a.m., Akanksha Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 4:14 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw pointer by Owned pointer
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp 70491375a6cd8988a33e3f18870c9170a37c0f17 
>   src/slave/containerizer/external_containerizer.cpp 42c67f548caf7bddbe131e0dfa7d74227d8c2593 
> 
> Diff: https://reviews.apache.org/r/32233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>