You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/10/19 17:02:00 UTC
[jira] [Work logged] (HIVE-25625) Drop TestCompareCliDriver and
related code from tests
[ https://issues.apache.org/jira/browse/HIVE-25625?focusedWorklogId=667140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667140 ]
ASF GitHub Bot logged work on HIVE-25625:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 17:01
Start Date: 19/Oct/21 17:01
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request #2732:
URL: https://github.com/apache/hive/pull/2732
### What changes were proposed in this pull request?
1. Drop `DummyCliDriver` and related code
2. Drop TestCompareCliDriver and related code
3. Drop unused classes/methods used from the above
### Why are the changes needed?
1. Facilitate code evolution
2. Reduce maintenance overhead
For more info check HIVE-25624 and HIVE-25625.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Mainly refactoring so no explicit tests required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 667140)
Remaining Estimate: 0h
Time Spent: 10m
> Drop TestCompareCliDriver and related code from tests
> -----------------------------------------------------
>
> Key: HIVE-25625
> URL: https://issues.apache.org/jira/browse/HIVE-25625
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The driver has been introduced back in 2015 (HIVE-6010) aiming to run queries with vectorization on/off and comparing the results. However it didn't receive much attention since then and currently only two queries are run with this driver.
> The majority of tests aiming to ensure vectorization works correctly use the {{TestMiniLlapLocalCliDriver}} and run a query twice switching on/off the necessary properties.
> Summing up having the [TestCompareCliDriver|https://github.com/apache/hive/blob/d521f149fade25f74e7ca28fa399103684a80580/itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestCompareCliDriver.java] in the repo leads to extra code maintenance cost without significant benefit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)