You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by John Vines <vi...@apache.org> on 2013/11/01 00:19:01 UTC

Review Request 15157: ACCUMULO-803 Add Reverse Logical Time as a Time Type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15157/
-----------------------------------------------------------

Review request for accumulo and Drew Farris.


Bugs: ACCUMULO-803
    https://issues.apache.org/jira/browse/ACCUMULO-803


Repository: accumulo


Description
-------

Updated Drew Farris' patch to master. Couldn't easily update ReverseLogicalTimeTest, so I commented it out for now. Wanted to get up to date and on review board before it got forgotten again.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/TimeType.java 3f5de94 
  core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 3dcab11 
  core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateTableCommand.java 0ad787d 
  docs/src/main/latex/accumulo_user_manual/chapters/table_configuration.tex 5ecbf05 
  server/src/main/java/org/apache/accumulo/server/tabletserver/TabletTime.java c7cfc59 
  test/src/main/java/org/apache/accumulo/test/functional/ReverseLogicalTimeTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/15157/diff/


Testing
-------


Thanks,

John Vines

Re: Review Request 15157: ACCUMULO-803 Add Reverse Logical Time as a Time Type

Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15157/#review28010
-----------------------------------------------------------



docs/src/main/latex/accumulo_user_manual/chapters/table_configuration.tex
<https://reviews.apache.org/r/15157/#comment54466>

    Update doc to reflect correct version.



test/src/main/java/org/apache/accumulo/test/functional/ReverseLogicalTimeTest.java
<https://reviews.apache.org/r/15157/#comment54467>

    Needs working tests.
    
    Tests should also cover:
    1. deletes
    2. using VersioningIterator
    3. combiners
    4. seeking with/without deletes and multiple versions


- Christopher Tubbs


On Oct. 31, 2013, 7:19 p.m., John Vines wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15157/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 7:19 p.m.)
> 
> 
> Review request for accumulo and Drew Farris.
> 
> 
> Bugs: ACCUMULO-803
>     https://issues.apache.org/jira/browse/ACCUMULO-803
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Updated Drew Farris' patch to master. Couldn't easily update ReverseLogicalTimeTest, so I commented it out for now. Wanted to get up to date and on review board before it got forgotten again.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TimeType.java 3f5de94 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 3dcab11 
>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/CreateTableCommand.java 0ad787d 
>   docs/src/main/latex/accumulo_user_manual/chapters/table_configuration.tex 5ecbf05 
>   server/src/main/java/org/apache/accumulo/server/tabletserver/TabletTime.java c7cfc59 
>   test/src/main/java/org/apache/accumulo/test/functional/ReverseLogicalTimeTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15157/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Vines
> 
>