You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 12:35:04 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2099: Return reference from UnionArray::child (#2035)
tustvold opened a new pull request, #2099:
URL: https://github.com/apache/arrow-rs/pull/2099
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2035
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See #2035
# What changes are included in this PR?
Changes UnionArray::child to return a reference
# Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2099: Return reference from UnionArray::child (#2035)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2099:
URL: https://github.com/apache/arrow-rs/pull/2099#issuecomment-1187348061
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2099](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28af32c) into [master](https://codecov.io/gh/apache/arrow-rs/commit/a6379fe9818de3133a80700b7b8d6d9d59b29e37?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6379fe) will **increase** coverage by `0.02%`.
> The diff coverage is `88.21%`.
> :exclamation: Current head 28af32c differs from pull request most recent head ceb6b73. Consider uploading reports for the commit ceb6b73 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2099 +/- ##
==========================================
+ Coverage 83.70% 83.73% +0.02%
==========================================
Files 224 225 +1
Lines 58967 59362 +395
==========================================
+ Hits 49360 49704 +344
- Misses 9607 9658 +51
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_decimal.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RlY2ltYWwucnM=) | `90.59% <ø> (ø)` | |
| [parquet/src/arrow/record\_reader/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvcmVjb3JkX3JlYWRlci9tb2QucnM=) | `89.17% <ø> (ø)` | |
| [parquet/src/basic.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYmFzaWMucnM=) | `91.49% <ø> (ø)` | |
| [parquet/src/column/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3JlYWRlci5ycw==) | `62.00% <ø> (ø)` | |
| [parquet/src/column/reader/decoder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3JlYWRlci9kZWNvZGVyLnJz) | `63.38% <0.00%> (-5.86%)` | :arrow_down: |
| [parquet/src/file/statistics.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZmlsZS9zdGF0aXN0aWNzLnJz) | `91.49% <78.57%> (-1.07%)` | :arrow_down: |
| [parquet/src/data\_type.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZGF0YV90eXBlLnJz) | `74.25% <80.35%> (-0.51%)` | :arrow_down: |
| [parquet/src/encodings/decoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2RlY29kaW5nLnJz) | `88.70% <85.79%> (-0.84%)` | :arrow_down: |
| [parquet/src/column/writer/encoder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3dyaXRlci9lbmNvZGVyLnJz) | `88.46% <88.46%> (ø)` | |
| [arrow/src/array/builder/decimal\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvZGVjaW1hbF9idWlsZGVyLnJz) | `83.03% <90.90%> (-2.34%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/arrow-rs/pull/2099/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6379fe...ceb6b73](https://codecov.io/gh/apache/arrow-rs/pull/2099?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2099: Return reference from UnionArray::child (#2035)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2099:
URL: https://github.com/apache/arrow-rs/pull/2099#issuecomment-1188324573
Benchmark runs are scheduled for baseline = 6a37d9f5ff69be0d5c8d73300e79e08c93803df1 and contender = 619be77a6aeaf31c524f3a25973c4941ac267a63. 619be77a6aeaf31c524f3a25973c4941ac267a63 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3a5d05ebdcc64bfba00f979e10c61ebb...eadc6bc5ae084d7bbfc3e5b08d9ab56a/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6ac8a608f5774c419607c057b5fd4c5f...a23d399e59e9488baed4c805e54b8162/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0c551c4765214061b3586a98a6acd022...3dfd2cba514d4b6590e84e7a53823e5b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e29db4c83abd4db985f0df59213a2918...d606f692f859436a810a0c73127e2240/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2099: Return reference from UnionArray::child (#2035)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2099:
URL: https://github.com/apache/arrow-rs/pull/2099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org