You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/05/11 10:57:58 UTC
Review Request 59172: RANGER-1571 : Code Improvement To Follow Best
Practices
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59172/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Repository: ranger
Description
-------
Code Improvement To Follow Best Practices.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 96645b9
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java f32355a
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java f1248bc
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 0d97298
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 0feecfe
Diff: https://reviews.apache.org/r/59172/diff/1/
Testing
-------
1. Tested Ranger Admin & Ranger KMS rest calls.
2. Verified Test-Connection for plugins on simple as well as on kerberized environment.
Thanks,
bhavik patel
Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow
Best Practices
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59172/#review174761
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On May 12, 2017, 5:54 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59172/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 5:54 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code Improvement To Follow Best Practices.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 96645b9
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java f32355a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java f1248bc
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 0d97298
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 0feecfe
>
>
> Diff: https://reviews.apache.org/r/59172/diff/2/
>
>
> Testing
> -------
>
> 1. Tested Ranger Admin & Ranger KMS rest calls.
> 2. Verified Test-Connection for plugins on simple as well as on kerberized environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow
Best Practices
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59172/#review174765
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On May 12, 2017, 5:54 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59172/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 5:54 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code Improvement To Follow Best Practices.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 96645b9
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java f32355a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java f1248bc
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 0d97298
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 0feecfe
>
>
> Diff: https://reviews.apache.org/r/59172/diff/2/
>
>
> Testing
> -------
>
> 1. Tested Ranger Admin & Ranger KMS rest calls.
> 2. Verified Test-Connection for plugins on simple as well as on kerberized environment.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow
Best Practices
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59172/
-----------------------------------------------------------
(Updated May 12, 2017, 5:54 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Repository: ranger
Description
-------
Code Improvement To Follow Best Practices.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 96645b9
agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java f32355a
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java f1248bc
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 0d97298
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 0feecfe
Diff: https://reviews.apache.org/r/59172/diff/2/
Changes: https://reviews.apache.org/r/59172/diff/1-2/
Testing
-------
1. Tested Ranger Admin & Ranger KMS rest calls.
2. Verified Test-Connection for plugins on simple as well as on kerberized environment.
Thanks,
bhavik patel
Re: Review Request 59172: RANGER-1571 : Code Improvement To Follow
Best Practices
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59172/#review174656
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
Line 34 (original), 34 (patched)
<https://reviews.apache.org/r/59172/#comment247859>
Remove this unused import. This will create a PMD violation.
- Velmurugan Periasamy
On May 11, 2017, 10:57 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59172/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 10:57 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code Improvement To Follow Best Practices.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 96645b9
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java f32355a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java f1248bc
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 0d97298
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 0feecfe
>
>
> Diff: https://reviews.apache.org/r/59172/diff/1/
>
>
> Testing
> -------
>
> 1. Tested Ranger Admin & Ranger KMS rest calls.
> 2. Verified Test-Connection for plugins on simple as well as on kerberized environment.
>
>
> Thanks,
>
> bhavik patel
>
>