You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/09 08:47:23 UTC
[GitHub] [flink] GJL opened a new pull request #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
GJL opened a new pull request #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684
## What is the purpose of the change
*This removes unused methods `getVertex()` and `getResultPartition()` from `SchedulingTopology`*
## Brief change log
- *See commits*
## Verifying this change
This change is already covered by existing tests, such as *`DefaultExecutionTopologyTest`*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559283",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159559283) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274)
* 09d841a714c95429150c94c242cd0e290fd6a95e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559283",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"triggerType" : "PUSH"
}, {
"hash" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160048120",
"triggerID" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"triggerType" : "PUSH"
}, {
"hash" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7403",
"triggerID" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159559283) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274)
* 09d841a714c95429150c94c242cd0e290fd6a95e UNKNOWN
* 321ff0b2e1f4a418b42cb5ef13da67309d9411cf Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160048120) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7403)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #11684: [FLINK-17050][runtime]
Remove methods getVertex() and getResultPartition() from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11684: [FLINK-17050][runtime]
Remove methods getVertex() and getResultPartition() from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #11684: [FLINK-17050][runtime]
Remove methods getVertex() and getResultPartition() from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611438114
Merging as soon as build is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559283",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159559283) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274)
* 09d841a714c95429150c94c242cd0e290fd6a95e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559283",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"triggerType" : "PUSH"
}, {
"hash" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "321ff0b2e1f4a418b42cb5ef13da67309d9411cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/159559283) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274)
* 09d841a714c95429150c94c242cd0e290fd6a95e UNKNOWN
* 321ff0b2e1f4a418b42cb5ef13da67309d9411cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11684:
[FLINK-17050][runtime] Remove methods getVertex() and getResultPartition()
from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611422199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559283",
"triggerID" : "482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d",
"triggerType" : "PUSH"
}, {
"hash" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09d841a714c95429150c94c242cd0e290fd6a95e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159559283) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7274)
* 09d841a714c95429150c94c242cd0e290fd6a95e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11684: [FLINK-17050][runtime]
Remove methods getVertex() and getResultPartition() from SchedulingTopology
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11684: [FLINK-17050][runtime] Remove methods getVertex() and getResultPartition() from SchedulingTopology
URL: https://github.com/apache/flink/pull/11684#issuecomment-611414374
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 482f7e2fb416e8b5154ec6cd5ecb0a7c7edd556d (Thu Apr 09 08:54:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services