You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/11/29 07:47:59 UTC
[PR] [FIX](array )fix array literal in fe [doris]
amorynan opened a new pull request, #27750:
URL: https://github.com/apache/doris/pull/27750
## Proposed changes
Issue Number: close #xxx
fix array<null> literal in fe const fold logic
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1837320421
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.44 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17164251730 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27750:
URL: https://github.com/apache/doris/pull/27750#discussion_r1408896579
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NullLiteral.java:
##########
@@ -101,6 +101,11 @@ public String getStringValue() {
return "NULL";
}
+ @Override
+ public String getStringValueInFe() {
+ return null;
Review Comment:
add a simple case just select all type primitive type in select list. such as
```sql
SELECT 1, 1.1, cast(1.1 as double), null, ....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835291402
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27750:
URL: https://github.com/apache/doris/pull/27750#discussion_r1408905510
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NullLiteral.java:
##########
@@ -101,6 +101,11 @@ public String getStringValue() {
return "NULL";
}
+ @Override
+ public String getStringValueInFe() {
+ return null;
Review Comment:
no, origin logic just data.add(null) , here just keep origin logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835696078
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.56 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17166808073 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1833162169
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.66 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162811225 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835543440
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1833069038
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #27750:
URL: https://github.com/apache/doris/pull/27750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835565579
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1837298277
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1837371676
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1833508783
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 08e66505c67e28fd10f19abcb9b1b0d5ebb986f1, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4909 4618 4632 4618
q2 355 141 142 141
q3 1512 1277 1288 1277
q4 1149 959 967 959
q5 3266 3258 3243 3243
q6 253 130 133 130
q7 1035 507 515 507
q8 2297 2288 2238 2238
q9 6982 6968 6978 6968
q10 3287 3371 3371 3371
q11 344 211 211 211
q12 352 215 210 210
q13 4679 3880 3832 3832
q14 253 227 211 211
q15 583 538 526 526
q16 444 418 381 381
q17 1036 726 631 631
q18 8244 8140 7718 7718
q19 1574 1548 1549 1548
q20 574 313 328 313
q21 3442 2997 2985 2985
q22 377 301 307 301
Total cold run time: 46947 ms
Total hot run time: 42319 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4610 4608 4589 4589
q2 322 242 242 242
q3 3758 3764 3745 3745
q4 2541 2532 2532 2532
q5 6215 6233 6221 6221
q6 247 124 128 124
q7 2592 2051 1983 1983
q8 3786 3700 3749 3700
q9 9466 9450 9432 9432
q10 4088 4171 4166 4166
q11 658 541 519 519
q12 842 649 646 646
q13 4369 3656 3653 3653
q14 273 260 248 248
q15 592 517 534 517
q16 522 490 529 490
q17 2141 2101 2104 2101
q18 9563 9063 9902 9063
q19 1787 1781 1769 1769
q20 2302 1995 1981 1981
q21 7332 7018 6927 6927
q22 677 584 587 584
Total cold run time: 68683 ms
Total hot run time: 65232 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835649923
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835540982
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27750:
URL: https://github.com/apache/doris/pull/27750#discussion_r1408895385
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NullLiteral.java:
##########
@@ -101,6 +101,11 @@ public String getStringValue() {
return "NULL";
}
+ @Override
+ public String getStringValueInFe() {
+ return null;
Review Comment:
so all NullLiteral will return lower case null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27750:
URL: https://github.com/apache/doris/pull/27750#discussion_r1408897365
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NullLiteral.java:
##########
@@ -101,6 +101,11 @@ public String getStringValue() {
return "NULL";
}
+ @Override
+ public String getStringValueInFe() {
+ return null;
Review Comment:
btw, u should also add ut to ensure `getStringValueInFe` return right string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835291440
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835689819
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 54afffd540ee367a6592cb37b15c4afc42ba88f9, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4891 4699 4647 4647
q2 351 174 160 160
q3 1520 1319 1308 1308
q4 1152 986 984 984
q5 3234 3230 3229 3229
q6 251 133 131 131
q7 1036 510 565 510
q8 2237 2226 2327 2226
q9 6964 6960 6932 6932
q10 3270 3362 3348 3348
q11 341 203 213 203
q12 407 255 239 239
q13 4668 3928 3875 3875
q14 248 212 223 212
q15 593 545 534 534
q16 430 390 388 388
q17 1044 667 600 600
q18 7845 7434 7486 7434
q19 1575 1571 1514 1514
q20 564 338 304 304
q21 3415 2970 3012 2970
q22 373 308 308 308
Total cold run time: 46409 ms
Total hot run time: 42056 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4605 4583 4645 4583
q2 317 203 236 203
q3 3734 3718 3709 3709
q4 2515 2499 2493 2493
q5 6109 6103 6099 6099
q6 244 126 128 126
q7 2577 1997 1945 1945
q8 3711 3645 3680 3645
q9 9456 9411 9410 9410
q10 4030 4209 4255 4209
q11 610 471 464 464
q12 817 664 676 664
q13 4398 3616 3617 3616
q14 273 254 241 241
q15 593 534 538 534
q16 521 458 491 458
q17 2129 2067 2067 2067
q18 9362 8666 8932 8666
q19 1811 1802 1768 1768
q20 2313 1999 1991 1991
q21 7016 6827 6663 6663
q22 633 560 571 560
Total cold run time: 67774 ms
Total hot run time: 64114 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array )fix array literal in fe [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27750:
URL: https://github.com/apache/doris/pull/27750#issuecomment-1835576658
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org