You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Marshall Shi <sh...@cn.ibm.com> on 2012/07/20 02:31:24 UTC
Re: Review Request: With declarative actions,
if two gadgets claim the same 'id' there is no warning that only one gadget
will function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6043/
-----------------------------------------------------------
(Updated July 20, 2012, 12:31 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Description
-------
With declarative actions, if two gadgets claim the same 'id' there is no warning that only one gadget will function.
This issue will be nearly impossible to debug in a customer environment.
This addresses bug shindig-1819.
https://issues.apache.org/jira/browse/shindig-1819
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1344059
Diff: https://reviews.apache.org/r/6043/diff/
Testing
-------
Thanks,
Marshall Shi
Re: Review Request: With declarative actions,
if two gadgets claim the same 'id' there is no warning that only one gadget
will function.
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6043/#review9297
-----------------------------------------------------------
Ship it!
Committed revision 1363663. Please close the review. Thanks!
- Ryan Baxter
On July 20, 2012, 12:31 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6043/
> -----------------------------------------------------------
>
> (Updated July 20, 2012, 12:31 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> With declarative actions, if two gadgets claim the same 'id' there is no warning that only one gadget will function.
> This issue will be nearly impossible to debug in a customer environment.
>
>
> This addresses bug shindig-1819.
> https://issues.apache.org/jira/browse/shindig-1819
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1344059
>
> Diff: https://reviews.apache.org/r/6043/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marshall Shi
>
>